From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by dpdk.org (Postfix) with ESMTP id 8212AB5C7 for ; Wed, 18 Feb 2015 02:55:00 +0100 (CET) Received: by paceu11 with SMTP id eu11so10741308pac.7 for ; Tue, 17 Feb 2015 17:55:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=d6vNf8uJ3+hohSodDY+3EKsZ2BxIji00lrv8tQJvjgI=; b=Uw2V+efKxVYI/pivJ5luN7LACDnyFO0/4kEbqyYNCxTzqRiHx6Br3It8NMmk9p3LpI 7wscuzv/k3rmfc+PLwFO+hACCXusl7rlIdsn8uL2Htkjjx2HFFOavJxAWM56jd47cath i5jL8VbZZL/cUlsvCNBkfRAb16+S9Bs201KQ+tF6Zux7E30rau3n27Z+uVRBkKPEpn8U CtbbpZkjzKT8AL7Fg8s15Y5icdPQOJUwlhw1ZyMN0oRrf1rC12CEZ6sUCIzrkqxHqtbd oWfEwGdkqLo7fYfVnkaLddbGbg7hZsDetUEUMxYugzwnrHabN7DPmB1kfwbbP2Ei0A0y JwmA== X-Gm-Message-State: ALoCoQm+pzOZjoblvTu6SQKivD0D6zhvMaL9rHKnmuqVEybL/44j8QP8Q22WMePb+195SpjcDMl9 X-Received: by 10.68.244.2 with SMTP id xc2mr2779244pbc.45.1424224499937; Tue, 17 Feb 2015 17:54:59 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id ei3sm18046995pbc.91.2015.02.17.17.54.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Feb 2015 17:54:59 -0800 (PST) Message-ID: <54E3F0F0.1030102@igel.co.jp> Date: Wed, 18 Feb 2015 10:54:56 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Thomas Monjalon References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp> <2372286.XQlcQsOEBg@xps13> <54E2DC38.7000907@igel.co.jp> <1518995.cYPUuEs3Fv@xps13> In-Reply-To: <1518995.cYPUuEs3Fv@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, Neil Horman Subject: Re: [dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 01:55:01 -0000 On 2015/02/18 9:31, Thomas Monjalon wrote: > 2015-02-17 15:14, Tetsuya Mukawa: >> On 2015/02/17 9:36, Thomas Monjalon wrote: >>> 2015-02-16 13:14, Tetsuya Mukawa: >>> Is uint8_t sill a good size for hotpluggable virtual device ids? >> I am not sure it's enough, but uint8_t is widely used in "rte_ethdev.c= " >> as port id. >> If someone reports it doesn't enough, I guess it will be the time to >> write a patch to change all uint_8 in one patch. > It's a big ABI breakage. So if we feel it's going to be required, > it's better to do it now in 2.0 release I think. > > Any opinion? > Hi Thomas, I agree with it. I will add an one more patch to change uint8_t to uint16_t. Thanks, Tetsuya