From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mukawa@igel.co.jp>
Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com
 [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id E7B37B4BD
 for <dev@dpdk.org>; Wed, 18 Feb 2015 10:37:22 +0100 (CET)
Received: by pablf10 with SMTP id lf10so13370768pab.12
 for <dev@dpdk.org>; Wed, 18 Feb 2015 01:37:22 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=Sv9iFcksgcs65TQy5jhfD3on0KQUdRszagkCtxscXyE=;
 b=WkK3ZCKYSlBr3wonVMiFPZ/MynJUav6tjWPfhikaY/oQlL+z8PtEdh4wY89OV0DIZl
 Z4yTax32ybZ252JlFd+mx6kE1iyiFpQmwbr5zNAtZoXtzNE4JNxZXQa8dvZPz+3OrpLn
 MdiLlOU4Twd4n4HU21+h+FlNxe3PCkAmtdN4q8YBUBix2hxpDL/5ZbYjICLfAjYelKtJ
 THcczDi+1m9IDEIiWSYZRvtc2ytB9dwKR5pP6NTOZrvT+jStVlCrCnD3RmD4T/v8cEHC
 a4qIFTzCq6kA71KEOEiES8aun52YAhD6Isk1S1ccuhSu4+kjmgaHTPeF/XUPpOlKntfK
 BWbg==
X-Gm-Message-State: ALoCoQk5kIHP+p3bEZp5U4zPkJ2+vDJSdguJGJW2IufWOk6qGUhXx0ejhbk18iN7zWj5shRPd5Tb
X-Received: by 10.70.12.162 with SMTP id z2mr17963817pdb.7.1424252242257;
 Wed, 18 Feb 2015 01:37:22 -0800 (PST)
Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132])
 by mx.google.com with ESMTPSA id cb9sm20320614pad.46.2015.02.18.01.37.20
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 18 Feb 2015 01:37:21 -0800 (PST)
Message-ID: <54E45D4F.7080001@igel.co.jp>
Date: Wed, 18 Feb 2015 18:37:19 +0900
From: Tetsuya Mukawa <mukawa@igel.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp>
 <2770102.I27SuxhSqW@xps13> <54E2DC82.8070901@igel.co.jp>
 <3062823.xy5khOG9OG@xps13>
In-Reply-To: <3062823.xy5khOG9OG@xps13>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for
 unmapping igb_uio resources
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Feb 2015 09:37:23 -0000

On 2015/02/18 10:09, Thomas Monjalon wrote:
> 2015-02-17 15:15, Tetsuya Mukawa:
>> On 2015/02/17 10:11, Thomas Monjalon wrote:
>>> 2015-02-16 13:14, Tetsuya Mukawa:
>>>> +#ifdef ENABLE_HOTPLUG
>>> Please avoid using #ifdef if not really necessary.
>> I agree with you.
>> In this case, only hotplug functions call pci_unmap_resource().
>> So this will be needed.
> Why is it needed?

It was my misunderstanding. Yes, we can remove it.
I will fix it.

Thanks,
Tetsuya