From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id DD208B472 for ; Wed, 18 Feb 2015 11:47:57 +0100 (CET) Received: by mail-wi0-f173.google.com with SMTP id bs8so40014783wib.0 for ; Wed, 18 Feb 2015 02:47:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=jR+g9rZphxiTRIZgn8mA8LE/D0rP8cLziBN5PZS8KQc=; b=O4jm6pbxyskOYTfm6J6MXudIzt18H/TfBdNuUuCP+BvCCDFKI6D8ZppVFOIRJye+cg WqwFwV6IAgXhpuDy7Pe6JVzJbGkpG/cn5gMZxw7JueZtxfKnuOg7QMRjNmOAA6QKDapv THPdigFuKlmPho7bPxmvy7J3WWiekd4Hd5+eGxBHRYlrw39en2ImWBsoIV9leD41g0KQ xo7sb5vwRAyZTkf//ldlwNSHnhkPxJzgJvds/vaYNi4Bahge7zNK5l40V59k1+zW/Qg+ CWrr5K0baiDuKDJiZ5cNwxcfZpLDH2/4cJAf+NKLIY8SqgVcnfj1i7apN3q2oyhFgz8D 1SKQ== X-Gm-Message-State: ALoCoQkBeeJ1EujNes9hy7JWM6vvmd/Cj0sTx5IUxEJ0Ls9/NhvOkectg5Np2rEpIOBkj12t/Qyu X-Received: by 10.180.8.10 with SMTP id n10mr3497211wia.79.1424256477745; Wed, 18 Feb 2015 02:47:57 -0800 (PST) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id dj4sm31969671wjc.13.2015.02.18.02.47.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Feb 2015 02:47:57 -0800 (PST) Message-ID: <54E46DDE.3090805@6wind.com> Date: Wed, 18 Feb 2015 11:47:58 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Bruce Richardson References: <1424102913-18944-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1424102913-18944-3-git-send-email-sergio.gonzalez.monroy@intel.com> <54E45888.7070603@6wind.com> <20150218093548.GA14884@bricha3-MOBL3> <2601191342CEEE43887BDE71AB977258213EF5E4@irsmsx105.ger.corp.intel.com> <20150218100003.GA14728@bricha3-MOBL3> <54E46612.7050809@6wind.com> <20150218102253.GA6804@bricha3-MOBL3> <54E46A8C.9010105@6wind.com> <20150218103703.GB6804@bricha3-MOBL3> In-Reply-To: <20150218103703.GB6804@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/2] Remove RTE_MBUF_REFCNT references X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 10:47:58 -0000 Hi, On 02/18/2015 11:37 AM, Bruce Richardson wrote: >>> How was this managed before, since refcnt field seems to be necessary in order >>> to effectively manage indirect mbufs? Is this just the case that this is something >>> that never worked and that needs to be solved, or is it something that was >>> working that this patch will now break? >> >> This is something that never worked before: refcounts are not compatible >> with reserving private data in mbufs. This patch does not change the >> issue, it is still there. >> >> Before the patch, an application that wanted to reserve a private >> data could disable refcounts at compile-time. >> After the patch, the solution is just to avoid using refcounts. >> >> Regards, >> Olivier >> > Thanks for clarifying. > So, you ok with this patch as a step in the right direction? Yep, Acked-by: Olivier Matz