From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-we0-f173.google.com (mail-we0-f173.google.com
 [74.125.82.173]) by dpdk.org (Postfix) with ESMTP id 3673DB53A
 for <dev@dpdk.org>; Thu, 19 Feb 2015 10:50:13 +0100 (CET)
Received: by wesw55 with SMTP id w55so6182305wes.4
 for <dev@dpdk.org>; Thu, 19 Feb 2015 01:50:13 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=bdL9a6vAFS4qk0iS6bekqDRsp7nbN4pfzueOHHsftj4=;
 b=fXPZeC+LfUCO8PFtWk+7N8Uqq7zaRnODjNxM7JWSCaO9wrKhIFG/DSeX8ib0PV7t0g
 kAGYoK3R6GL2wUskz9fAcyjSNQXiFwAaBNZjqtVO3FAjBeEA5uDkFGmlb88oijvMakew
 2sEctrbkCEpqlccLPB2ZPZ+MX40PFtECgp+OeyLWGKaQWKSxd6g/F+p3LUlbwSY06Xl9
 Mc0s5u/RnNCrCSLZ0v8qNGbK2DgFFcoLLjDWrJAiVr2J/oCdJd+QCJ4DDLELgSTHvrhF
 shv+pbJcEwxoHFs9Go1gjJ+4PziQbiXItpmGfKDIFyKr2CsC67uRh6izn1G2gurmRCm2
 tQnw==
X-Gm-Message-State: ALoCoQma6MHg4la92IHJpZPUYkFrlIPJ3/s0k321oO+MYuVQyFEr2MtESoSdJP4Vi2UjGiz8cCbR
X-Received: by 10.194.223.5 with SMTP id qq5mr7568118wjc.152.1424339413022;
 Thu, 19 Feb 2015 01:50:13 -0800 (PST)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id h11sm25283259wic.14.2015.02.19.01.50.12
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 19 Feb 2015 01:50:12 -0800 (PST)
Message-ID: <54E5B1D3.4070403@6wind.com>
Date: Thu, 19 Feb 2015 10:50:11 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.2.0
MIME-Version: 1.0
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>, 
 dev@dpdk.org
References: <1423660055-23920-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1424271498-23583-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1424271498-23583-2-git-send-email-sergio.gonzalez.monroy@intel.com>
 <54E5AAF9.9010705@6wind.com>
In-Reply-To: <54E5AAF9.9010705@6wind.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 1/6] reorder: new reorder library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2015 09:50:13 -0000

Hi,

On 02/19/2015 10:20 AM, Olivier MATZ wrote:
> Hi Sergio,
>
> On 02/18/2015 03:58 PM, Sergio Gonzalez Monroy wrote:
>> This library provides reordering capability for out of order mbufs based
>> on a sequence number in the mbuf structure.
>>
>> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>> Signed-off-by: Richardson Bruce <bruce.richardson@intel.com>
>> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
>>
>> [...]
>>
>> --- a/lib/librte_mbuf/rte_mbuf.h
>> +++ b/lib/librte_mbuf/rte_mbuf.h
>> @@ -289,6 +289,9 @@ struct rte_mbuf {
>>           uint32_t usr;      /**< User defined tags. See
>> @rte_distributor_process */
>>       } hash;                   /**< hash information */
>>
>> +    /* sequence number - field used in distributor and reorder
>> library */
>> +    uint32_t seqn;
>> +
>>       /* second cache line - fields only used in slow path or on TX */
>>       MARKER cacheline1 __rte_cache_aligned;
>>
>
> Just one small comment about rte_mbuf: the comment should be in doxygen
> style.


I've just realized it's already applied. I'll submit a patch for this.

Olivier