From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 068B3B533 for ; Thu, 19 Feb 2015 12:09:55 +0100 (CET) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1JB9sTO020233 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 19 Feb 2015 06:09:55 -0500 Received: from localhost.localdomain (vpn1-6-118.ams2.redhat.com [10.36.6.118]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1JB9r8C004265; Thu, 19 Feb 2015 06:09:54 -0500 Message-ID: <54E5C481.6020701@redhat.com> Date: Thu, 19 Feb 2015 13:09:53 +0200 From: Panu Matilainen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Ananyev, Konstantin" , "dev@dpdk.org" References: <442c1d71592455d2f3c8df4cc944cc48c1092fc6.1424341431.git.pmatilai@redhat.com> <2601191342CEEE43887BDE71AB977258213F0C28@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258213F0C28@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Subject: Re: [dpdk-dev] [PATCH] i40e: fix build with gcc 5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 11:09:56 -0000 On 02/19/2015 01:05 PM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen >> Sent: Thursday, February 19, 2015 10:25 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] i40e: fix build with gcc 5 >> >> Eliminate embiguity in the condition which trips up a "logical not >> is only applied to the left..." warning from gcc 5, causing build >> failure with -Werror. >> >> Signed-off-by: Panu Matilainen >> --- >> lib/librte_pmd_i40e/i40e_rxtx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c >> index c9f1026..ede5405 100644 >> --- a/lib/librte_pmd_i40e/i40e_rxtx.c >> +++ b/lib/librte_pmd_i40e/i40e_rxtx.c >> @@ -613,7 +613,7 @@ check_rx_burst_bulk_alloc_preconditions(__rte_unused struct i40e_rx_queue *rxq) >> "rxq->nb_rx_desc=%d", >> rxq->rx_free_thresh, rxq->nb_rx_desc); >> ret = -EINVAL; >> - } else if (!(rxq->nb_rx_desc % rxq->rx_free_thresh) == 0) { >> + } else if (!(rxq->nb_rx_desc % rxq->rx_free_thresh == 0)) { > > Why just not: > else if (rxq->nb_rx_desc % rxq->rx_free_thresh != 0) > ? The same occurred to me right after hitting send, it'll make it a whole lot more obvious. I'll send another version. - Panu -