From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id 8A997B5B2 for ; Thu, 19 Feb 2015 14:29:48 +0100 (CET) Received: by pdjz10 with SMTP id z10so8825083pdj.12 for ; Thu, 19 Feb 2015 05:29:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=FTJ4KzvVuLBrG2vHCrObVTb6NCz4rjiZI39gSYvlZ7o=; b=K99Gg9FJmR4OUMz9ameAuPlUDvpJ9NndObS89PQLU3ta6GFAQK96Jf8AfsLki6d6IS +9rtm2zgmcgYLw8ySFhNpE+E6kaxbqJeLBNIAoPsLfmU1SWJoboHlV0ft+4DVM/mEG/P vvkP5CUXLdKq1CkAvUjUZyMGzUdUCDQwpZMd5AA2SXhZXIxk1ArwmfBavPAuR+YwyCf1 FReUn5GySkVclLLbV5p2Xz7vwTvSRluIEgOitZStgc/Yqj5WsFvFEvpCDzj4mMjhqOH2 8Rup+9OKqpohlBA68/pKeN7Qs2ueV4skTsHrK13ejCpyKsQkH6AfWI25Z0gVnbOuWNY9 8cqQ== X-Gm-Message-State: ALoCoQkk2L1ltuKR084wxMZJvWcWtsh244qbn+cS/zHDOgXA44XZsBiUD2uYlHuNO/mX2UKWSi1t X-Received: by 10.70.123.1 with SMTP id lw1mr8063278pdb.26.1424352587757; Thu, 19 Feb 2015 05:29:47 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id sq6sm23762107pbc.40.2015.02.19.05.29.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Feb 2015 05:29:47 -0800 (PST) Message-ID: <54E5E547.2020806@igel.co.jp> Date: Thu, 19 Feb 2015 22:29:43 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: michael.qiu@intel.com References: <1424060073-23484-12-git-send-email-mukawa@igel.co.jp> <1424314187-25177-1-git-send-email-mukawa@igel.co.jp> <1424314187-25177-3-git-send-email-mukawa@igel.co.jp> <5677937.pUHUTuZF0f@xps13> In-Reply-To: <5677937.pUHUTuZF0f@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v9 02/14] eal_pci: Add flag to hold kernel driver type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 13:29:49 -0000 On 2015/02/19 20:17, Thomas Monjalon wrote: >> @@ -152,6 +159,7 @@ struct rte_pci_device { >> uint16_t max_vfs; /**< sriov enable if not zero */ >> int numa_node; /**< NUMA node connection */ >> struct rte_devargs *devargs; /**< Device user arguments */ >> + enum rte_pt_driver pt_driver; /**< Driver of passthrough */ > [...] >> +static int >> +pci_get_kernel_driver_by_path(const char *filename, char *dri_name) > I think "kernel driver" is a good name. Why not using this name in the > pci_device struct to be more consistent? Hi Michael, Could you please let me know what do you think about it? Thanks Tetsuya > Thanks