From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 593EEB613 for ; Thu, 19 Feb 2015 15:05:15 +0100 (CET) Received: by padhz1 with SMTP id hz1so9693010pad.9 for ; Thu, 19 Feb 2015 06:05:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type:content-transfer-encoding; bh=7yb1Be8gV5pSnsBilAIT1fUI5oXLScJy9STpnd0zBus=; b=hWRBOMSkl4Al2zhgsTWjARqNrrtbbnEOMMQkul0xT/kaZU4gLU0CzWcnUsC+blkQFQ 5jJFr7r+BzZSgCgq0DgjPloHGXJBoeEZJDCsQ7pM4bF6RYP3K8zNzuxhCK3lJLc1mx+R P/fyKREjxbO7WSX0QfqJfoWUP2xwwqE+A3h2xkKmEofg2fP/mP+n15QPw7MSM1UoIhGl ve7Lp8iD9soOm9qT4TR/K5rciH+d57sp48ose4K0Vy9ZnH49ii6ly0yJwBQZmOqgFtL5 e9+Y7vhLqG7AZIpV0/txFS7U5ugOR4Z9GiFLO/q6Lg6cOtYJcl0cMY0f7GUQwjvycHWk FvgA== X-Gm-Message-State: ALoCoQnGlqcrgkWYsxV5QFBYxUdvzEcK7ljU33oJutnXW8T8UCSd4uBrDp8swoZ4yojv+BgFuDaL X-Received: by 10.66.241.71 with SMTP id wg7mr7708633pac.81.1424354714682; Thu, 19 Feb 2015 06:05:14 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id rx1sm23900896pbc.5.2015.02.19.06.05.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Feb 2015 06:05:14 -0800 (PST) Message-ID: <54E5ED96.9040402@igel.co.jp> Date: Thu, 19 Feb 2015 23:05:10 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] 2nd parameter of driver init function can be NULL using latest code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 14:05:15 -0000 Hi, It seems after applying below patch, 2nd parameter of PMD initialization code can be NULL when vdev option is like below. ---------------- commit c07691ae10894bb6bf284fed75829b95844eacdb devargs: remove limit on parameters length ---------------- Here is example vdev option --vdev 'eth_name0' (No option after driver name case) It seems some PMDs assumes 2nd parameter will be always not NULL, even if there is no option after driver name. For example, before applying the patch, here is a log of bond PMD. $ sudo ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 1 --vdev 'eth_bond0' -- -i EAL: Detected lcore 0 as core 0 on socket 0 EAL: Detected lcore 1 as core 1 on socket 0 EAL: Detected lcore 2 as core 2 on socket 0 EAL: Detected lcore 3 as core 3 on socket 0 EAL: Detected lcore 4 as core 4 on socket 0 EAL: Detected lcore 5 as core 5 on socket 0 EAL: Detected lcore 6 as core 6 on socket 0 EAL: Detected lcore 7 as core 7 on socket 0 EAL: Support maximum 128 logical core(s) by configuration. EAL: Detected 8 lcore(s) EAL: VFIO modules not all loaded, skip VFIO support... EAL: Setting up memory... EAL: Ask a virtual area of 0x280000000 bytes EAL: Virtual area found at 0x7ffd40000000 (size =3D 0x280000000) EAL: Requesting 10 pages of size 1024MB from socket 0 EAL: TSC frequency is ~3991438 KHz EAL: Master core 0 is ready (tid=3Df7fd6840) EAL: Initializing pmd_bond for eth_bond0 EAL: Mode must be specified only once for bonded device eth_bond0 PMD: ENICPMD trace: rte_enic_pmd_init EAL: Core 3 is ready (tid=3Df58e0700) EAL: Core 2 is ready (tid=3Df60e1700) EAL: Core 1 is ready (tid=3Df68e2700) EAL: PCI device 0000:02:00.0 on NUMA socket -1 EAL: probe driver: 8086:10b9 rte_em_pmd EAL: 0000:02:00.0 not managed by UIO driver, skipping EAL: Error - exiting with code: 1 Cause: No probed ethernet device After applying. $ sudo ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 1 --vdev 'eth_bond0' -- -i EAL: Detected lcore 0 as core 0 on socket 0 EAL: Detected lcore 1 as core 1 on socket 0 EAL: Detected lcore 2 as core 2 on socket 0 EAL: Detected lcore 3 as core 3 on socket 0 EAL: Detected lcore 4 as core 4 on socket 0 EAL: Detected lcore 5 as core 5 on socket 0 EAL: Detected lcore 6 as core 6 on socket 0 EAL: Detected lcore 7 as core 7 on socket 0 EAL: Support maximum 128 logical core(s) by configuration. EAL: Detected 8 lcore(s) EAL: VFIO modules not all loaded, skip VFIO support... EAL: Setting up memory... EAL: Ask a virtual area of 0x280000000 bytes EAL: Virtual area found at 0x7ffd40000000 (size =3D 0x280000000) EAL: Requesting 10 pages of size 1024MB from socket 0 EAL: TSC frequency is ~3991439 KHz EAL: Master core 0 is ready (tid=3Df7fd6840) EAL: Initializing pmd_bond for eth_bond0 $ It seems error is returned in PMD code. I am not sure this is an issue. But just in case I report it, because behavior is changed. Thanks, Tetsuya