From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 001D7B54A for ; Fri, 20 Feb 2015 09:50:53 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 20 Feb 2015 00:50:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,613,1418112000"; d="scan'208";a="669014957" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.3]) ([10.237.221.3]) by fmsmga001.fm.intel.com with ESMTP; 20 Feb 2015 00:50:24 -0800 Message-ID: <54E6F54F.40707@intel.com> Date: Fri, 20 Feb 2015 08:50:23 +0000 From: "Gonzalez Monroy, Sergio" User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Zhou Danny , dev@dpdk.org References: <1424353698-29837-1-git-send-email-danny.zhou@intel.com> In-Reply-To: <1424353698-29837-1-git-send-email-danny.zhou@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 0/5] Interrupt mode PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 08:50:54 -0000 On 19/02/2015 13:48, Zhou Danny wrote: > v4 changes > - Export interrupt enable/disable functions for shared libraries > - Adjust position of new-added structure fields and functions to > avoid breaking ABI > > v3 changes > - Add return value for interrupt enable/disable functions > - Move spinlok from PMD to L3fwd-power > - Remove unnecessary variables in e1000_mac_info > - Fix miscelleous review comments > > v2 changes > - Fix compilation issue in Makefile for missed header file. > - Consolidate internal and community review comments of v1 patch set. > > The patch series introduce low-latency one-shot rx interrupt into DPDK with > polling and interrupt mode switch control example. > > DPDK userspace interrupt notification and handling mechanism is based on UIO > with below limitation: > 1) It is designed to handle LSC interrupt only with inefficient suspended > pthread wakeup procedure (e.g. UIO wakes up LSC interrupt handling thread > which then wakes up DPDK polling thread). In this way, it introduces > non-deterministic wakeup latency for DPDK polling thread as well as packet > latency if it is used to handle Rx interrupt. > 2) UIO only supports a single interrupt vector which has to been shared by > LSC interrupt and interrupts assigned to dedicated rx queues. > > This patchset includes below features: > 1) Enable one-shot rx queue interrupt in ixgbe PMD(PF & VF) and igb PMD(PF only). > 2) Build on top of the VFIO mechanism instead of UIO, so it could support > up to 64 interrupt vectors for rx queue interrupts. > 3) Have 1 DPDK polling thread handle per Rx queue interrupt with a dedicated > VFIO eventfd, which eliminates non-deterministic pthread wakeup latency in > user space. > 4) Demonstrate interrupts control APIs and userspace NAIP-like polling/interrupt > switch algorithms in L3fwd-power example. > > Known limitations: > 1) It does not work for UIO due to a single interrupt eventfd shared by LSC > and rx queue interrupt handlers causes a mess. > 2) LSC interrupt is not supported by VF driver, so it is by default disabled > in L3fwd-power now. Feel free to turn in on if you want to support both LSC > and rx queue interrupts on a PF. > > Danny Zhou (5): > ethdev: add rx interrupt enable/disable functions > ixgbe: enable rx queue interrupts for both PF and VF > igb: enable rx queue interrupts for PF > eal: add per rx queue interrupt handling based on VFIO > l3fwd-power: enable one-shot rx interrupt and polling/interrupt mode > switch > > examples/l3fwd-power/main.c | 153 ++++++--- > lib/librte_eal/common/include/rte_eal.h | 12 + > lib/librte_eal/linuxapp/eal/Makefile | 1 + > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 190 ++++++++--- > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 12 +- > .../linuxapp/eal/include/exec-env/rte_interrupts.h | 4 + > lib/librte_ether/rte_ethdev.c | 43 +++ > lib/librte_ether/rte_ethdev.h | 59 ++++ > lib/librte_ether/rte_ether_version.map | 2 + > lib/librte_pmd_e1000/e1000_ethdev.h | 3 + > lib/librte_pmd_e1000/igb_ethdev.c | 228 +++++++++++-- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 365 ++++++++++++++++++++- > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 6 + > 13 files changed, 964 insertions(+), 114 deletions(-) > Series Acked-by: Sergio Gonzalez Monroy