From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgw.gov.kz (mgw.gov.kz [89.218.88.242]) by dpdk.org (Postfix) with ESMTP id 58F60ADB6 for ; Tue, 24 Feb 2015 04:02:03 +0100 (CET) Received: from mgw.gov.kz (mx.ctsat.kz [178.89.4.95]) by mgw.gov.kz with ESMTP id t1O31sTt022381-t1O31sTv022381; Tue, 24 Feb 2015 09:01:56 +0600 Received: from EXCASHUB1.rgp.local (192.168.40.51) by EdgeForefront.rgp.local (192.168.40.59) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 24 Feb 2015 09:00:21 +0600 Received: from [192.168.35.15] (192.168.35.15) by excashub1.rgp.local (192.168.40.48) with Microsoft SMTP Server (TLS) id 14.2.247.3; Tue, 24 Feb 2015 09:01:50 +0600 Message-ID: <54EBE934.8080707@sts.kz> Date: Tue, 24 Feb 2015 09:00:04 +0600 From: Yerden Zhumabekov User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Thomas Monjalon References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz> <54CF0D86.3090507@sts.kz> <20150219152129.GA17032@bricha3-MOBL3> <2302266.QHkfKt2YM8@xps13> In-Reply-To: <2302266.QHkfKt2YM8@xps13> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [192.168.35.15] X-FEAS-SYSTEM-WL: e_zhumabekov@sts.kz Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be platform-independent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 03:02:03 -0000 23.02.2015 23:36, Thomas Monjalon =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > 2015-02-19 15:21, Bruce Richardson: >> Confirmed, this worked for me too. >> Looking at the patches, they look good. However, one thing I think we = are missing >> is a unit test to verify that all our CRC implementations give the sam= e result. >> That would be useful as a sanity check of the software fallback especi= ally. The >> existing hash tests, test the hash table implementation rather than th= e >> mathematical argorithm used to compute the hash values. >> >> Overall, though, software fallback for CRC is something well worthwhil= e having. >> >> Series Acked-by: Bruce Richardson > Applied, thanks > > Note: running doxygen compilation helped me to find and fix a small > mismatch (parameter alg was flag in comment). Thanks, Bruce, Thomas. As for yielding the same hash value, I made a test which runs every CRC32 implementation across a number of randomly generated data sets. Results are equal on my trial run. I can post a patch for test_hash.c a bit later if this kind of check suffices. --=20 Sincerely, Yerden Zhumabekov State Technical Service Astana, KZ