From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id EA890ADB6 for ; Tue, 24 Feb 2015 10:09:12 +0100 (CET) Received: by mail-wi0-f182.google.com with SMTP id l15so23414836wiw.3 for ; Tue, 24 Feb 2015 01:09:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=0Ob9oFeI3l8uwG9Wzgo+apafbrQBUcTfuUbcSiP+xDY=; b=mTgPOPMTxScVIRUJz8Y/r1/WcySK37EkIJpOYyhWtHqK/7+s3WkTDzOU1Wtp/OJQCR I2i5NFSMFLX4Z6Lp4A/i+OH9jJ3y/YzLso517Z6JsfwtM4nVs7VQAhGhjDPSqzAFWJdn 28ncku17y8BcDoNXAakLIrKQDblHQjVGitc+/r7qZ7Y0dVOKKoz5X6arCjmlKGuSn5OT iZ+pjr6kGTVJrQFOc5gNohBDgkGEeLlOc4MNtKgK97EZEzZEY6NtXuFaabZOdbvoLtVC G/WWaoj8S/ZtmK+wJaA/t2RXyc3uTeYP9pGKLrWRMqXeRh/IZqa5xPTQaj3JBHPrbI5H aGbQ== X-Gm-Message-State: ALoCoQn/xqatZr0gDqUE9KWZEFBxLjSYubEOTz6zzFKGtlE4WXJ0p8KFA0y//v/P8/em2VTtnmx0 X-Received: by 10.180.19.193 with SMTP id h1mr28342564wie.2.1424768952802; Tue, 24 Feb 2015 01:09:12 -0800 (PST) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id hi6sm59267138wjc.34.2015.02.24.01.09.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 01:09:12 -0800 (PST) Message-ID: <54EC3FB7.60908@6wind.com> Date: Tue, 24 Feb 2015 10:09:11 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: "Zhang, Helin" , "dev@dpdk.org" References: <1422501365-12643-1-git-send-email-helin.zhang@intel.com> <1424156374-21768-1-git-send-email-helin.zhang@intel.com> <1424156374-21768-4-git-send-email-helin.zhang@intel.com> <54E30374.4010809@6wind.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 03/16] mbuf: add definitions of unified packet types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 09:09:13 -0000 Hi Helin, On 02/20/2015 03:26 PM, Zhang, Helin wrote: >> On 02/17/2015 07:59 AM, Helin Zhang wrote: >>> As there are only 6 bit flags in ol_flags for indicating packet types, >>> which is not enough to describe all the possible packet types hardware >>> can recognize. For example, i40e hardware can recognize more than 150 >>> packet types. Unified packet type is composed of L2 type, L3 type, L4 >>> type, tunnel type, inner L2 type, inner L3 type and inner L4 type >>> fields, and can be stored in 'struct rte_mbuf' of 32 bits field >>> 'packet_type'. >>> >>> Signed-off-by: Helin Zhang >> >> A formal definition of each flag is still missing. I explained several times why it's >> needed. We must be able to answer to these >> questions: >> >> - If I'm developing a PMD, what fields should I check in the packet >> to set a specific flag? >> - If I'm developing an application, if a specific flag is set, what >> checks can I skip? >> >> Example with RTE_PTYPE_L3_IPV4: >> >> - IP version field is 4 >> - no IP options (header size is 20) >> - layer 2 identified the packet as IP (ex: ethertype=0x800) >> >> I think we need such a definition for all packet types. > You meant we need a detailed description of each packet type, right? > If yes, I can add those information soon. Thanks for the helps! Yes, I think this would be really helpful. Thank you! Olivier