From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id A15F1AD97 for ; Tue, 24 Feb 2015 11:16:34 +0100 (CET) Received: by padfb1 with SMTP id fb1so34991598pad.8 for ; Tue, 24 Feb 2015 02:16:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=/AiGm5IsquqLs3b89RZfRtMshXZM/jgTxxAcydNjZyk=; b=CBzYFQtuqjPxSe6cLm4bA/4X/pcRLs50uh1QREH+Z58esS4WMNBIznMpgJlDPLtn0I yzpRvxgR4pxQ5zQzXNc9ejdBq8lYVxljpY5tV1vqQ0jfIGPE3DxUOsfiv0Fm2fo6dEuB h2OKVFH6sRiHiuNq5rDOQROIAYnfxSv2qEdN2MEINA22tEdjHvIfk2H++0YJO3W+N+WH 49kFoa2oXGmKwu+QuJwy4iSOTO3vucUCBuC2ErMtZsee+3/Gn7i7SJ1VfpgPofpyqtXj pMKY2wvNOzgK0xOEWk58B+4jRIrhLRl9WCqZPSwuUp3eNiMtib+vzcAsM6PUgvX4QHsC lv9A== X-Gm-Message-State: ALoCoQkZVbiW3RKG+8hf6Hctds9eAOy4x4Hcw4zBtU2gfWKdpwu6fxJJ2WHX+4GISD2Xh24Mp5fz X-Received: by 10.70.38.163 with SMTP id h3mr27608773pdk.95.1424772993583; Tue, 24 Feb 2015 02:16:33 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id ok1sm32780888pdb.53.2015.02.24.02.16.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 02:16:32 -0800 (PST) Message-ID: <54EC4F7B.6080907@igel.co.jp> Date: Tue, 24 Feb 2015 19:16:27 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: David Marchand , dev@dpdk.org References: <54E5ED96.9040402@igel.co.jp> <1424770891-19243-1-git-send-email-david.marchand@6wind.com> In-Reply-To: <1424770891-19243-1-git-send-email-david.marchand@6wind.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] devargs: restore empty devargs as "" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 10:16:34 -0000 On 2015/02/24 18:41, David Marchand wrote: > Following commit c07691ae1089, an implicit change has been done in the devargs > api. > This triggers problem in virtual pmds that did not check for parameters validity > as it was implicitely valid. > > Fix this by restoring the empty argument as "" and add a note in the api. > Restore associated tests. > > Fixes: c07691ae1089 ("devargs: remove limit on parameters length") > Reported-by: Tetsuya Mukawa > Signed-off-by: David Marchand > --- > app/test/test_devargs.c | 2 +- > lib/librte_eal/common/eal_common_devargs.c | 11 +++++++---- > lib/librte_eal/common/include/rte_devargs.h | 2 +- > 3 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c > index 08fb781..f7fc59c 100644 > --- a/app/test/test_devargs.c > +++ b/app/test/test_devargs.c > @@ -107,7 +107,7 @@ test_devargs(void) > devargs->pci.addr.devid != 0 || > devargs->pci.addr.function != 1) > goto fail; > - if (devargs->args) > + if (!devargs->args || strcmp(devargs->args, "") != 0) > goto fail; > free_devargs_list(); > > diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c > index 3aace08..eadd719 100644 > --- a/lib/librte_eal/common/eal_common_devargs.c > +++ b/lib/librte_eal/common/eal_common_devargs.c > @@ -73,10 +73,13 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str) > if (sep != NULL) { > sep[0] = '\0'; > devargs->args = strdup(sep + 1); > - if (devargs->args == NULL) { > - RTE_LOG(ERR, EAL, "cannot allocate for devargs args\n"); > - goto fail; > - } > + } else { > + devargs->args = strdup(""); > + } > + > + if (devargs->args == NULL) { > + RTE_LOG(ERR, EAL, "cannot allocate for devargs args\n"); > + goto fail; > } > > switch (devargs->type) { > diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h > index 996e180..6834333 100644 > --- a/lib/librte_eal/common/include/rte_devargs.h > +++ b/lib/librte_eal/common/include/rte_devargs.h > @@ -88,7 +88,7 @@ struct rte_devargs { > char drv_name[32]; > } virtual; > }; > - /** Arguments string as given by user. */ > + /** Arguments string as given by user or "" for no argument. */ > char *args; > }; > Hi David, I've confirmed this patch fixes the issue descried in above comment. Thanks, Tetsuya