DPDK patches and discussions
 help / color / mirror / Atom feed
From: Panu Matilainen <pmatilai@redhat.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x
Date: Tue, 24 Feb 2015 12:21:59 +0200	[thread overview]
Message-ID: <54EC50C7.7050105@redhat.com> (raw)
In-Reply-To: <CALwxeUt0oDQ5nZB00mAAA=MV7nmPaLCXxos-fvPv1yMnrdP6YQ@mail.gmail.com>

On 02/24/2015 12:09 PM, David Marchand wrote:
> On Tue, Feb 24, 2015 at 10:50 AM, Panu Matilainen <pmatilai@redhat.com
> <mailto:pmatilai@redhat.com>> wrote:
>
>     On 02/24/2015 11:25 AM, David Marchand wrote:
>
>         Hello Panu,
>
>         Looks like there is an issue with gcc 4.7 on my debian.
>
>         $ make config T=x86_64-native-linuxapp-gcc && make -j8
>         ../mk/toolchain/gcc/rte.__toolchain-compat.mk:46
>         <http://rte.toolchain-compat.mk:46>
>         <http://rte.toolchain-compat.__mk:46
>         <http://rte.toolchain-compat.mk:46>>: You are using GCC < 4.x.
>         This is
>         neither supported, nor tested.
>         ../mk/toolchain/gcc/rte.__toolchain-compat.mk:46
>         <http://rte.toolchain-compat.mk:46>
>         <http://rte.toolchain-compat.__mk:46
>         <http://rte.toolchain-compat.mk:46>>: You are using GCC < 4.x.
>         This is
>         neither supported, nor tested.
>
>         $ gcc -dumpversion
>         4.7
>
>
>     Meh. This seems to be a Debian specific modification to gcc,
>     discussed here and there including but not limited to:
>     https://bugs.debian.org/cgi-__bin/bugreport.cgi?bug=759038
>     <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759038>
>     https://bugs.launchpad.net/__ubuntu/+source/gcc-4.8/+bug/__1360404
>     <https://bugs.launchpad.net/ubuntu/+source/gcc-4.8/+bug/1360404>
>
>     Dunno about Ubuntu, but at least Ubuntu already changed it back. But
>     I guess there's no choice but to work around it anyway... Easiest
>     solution is probably just to drop the micro version out, back to the
>     granularity where it used to be.
>
>
> Yes, I suppose so, but then we are almost at square one :-)

Not really, the big deal about the change was to compare the version as 
a regular number instead of segmented comparison. Bringing in the 
micro-version was more of a side-effect than anything else, it just 
seemed simpler than having to cut out major.minor specifically.

So no big loss, just mildly annoying workaround for upstream deviation :)

	- Panu -

      parent reply	other threads:[~2015-02-24 10:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 12:11 [dpdk-dev] [PATCH] " Panu Matilainen
2015-02-20 14:04 ` Thomas Monjalon
2015-02-20 15:25   ` Panu Matilainen
2015-02-23 14:53 ` [dpdk-dev] [PATCH v2] " Panu Matilainen
2015-02-24  2:46   ` Thomas Monjalon
2015-02-24  9:25     ` David Marchand
2015-02-24  9:50       ` Panu Matilainen
2015-02-24 10:09         ` David Marchand
2015-02-24 10:21           ` David Marchand
2015-02-24 10:36             ` Mcnamara, John
2015-02-24 10:44               ` David Marchand
2015-02-24 10:50                 ` Bruce Richardson
2015-02-24 10:53                 ` Panu Matilainen
2015-02-24 10:58                 ` Mcnamara, John
2015-02-24 10:21           ` Panu Matilainen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EC50C7.7050105@redhat.com \
    --to=pmatilai@redhat.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).