From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8D8E9AD8B for ; Tue, 24 Feb 2015 11:22:03 +0100 (CET) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1OAM0nZ028989 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 24 Feb 2015 05:22:01 -0500 Received: from localhost.localdomain (vpn1-4-61.ams2.redhat.com [10.36.4.61]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1OALxiD009465; Tue, 24 Feb 2015 05:22:00 -0500 Message-ID: <54EC50C7.7050105@redhat.com> Date: Tue, 24 Feb 2015 12:21:59 +0200 From: Panu Matilainen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: David Marchand References: <7a06a1e8019a40d4175c6bc2e1d7e62cf956b291.1424261465.git.pmatilai@redhat.com> <1597878.lL4fhc8lIW@xps13> <54EC496C.7050200@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 10:22:04 -0000 On 02/24/2015 12:09 PM, David Marchand wrote: > On Tue, Feb 24, 2015 at 10:50 AM, Panu Matilainen > wrote: > > On 02/24/2015 11:25 AM, David Marchand wrote: > > Hello Panu, > > Looks like there is an issue with gcc 4.7 on my debian. > > $ make config T=x86_64-native-linuxapp-gcc && make -j8 > ../mk/toolchain/gcc/rte.__toolchain-compat.mk:46 > > >: You are using GCC < 4.x. > This is > neither supported, nor tested. > ../mk/toolchain/gcc/rte.__toolchain-compat.mk:46 > > >: You are using GCC < 4.x. > This is > neither supported, nor tested. > > $ gcc -dumpversion > 4.7 > > > Meh. This seems to be a Debian specific modification to gcc, > discussed here and there including but not limited to: > https://bugs.debian.org/cgi-__bin/bugreport.cgi?bug=759038 > > https://bugs.launchpad.net/__ubuntu/+source/gcc-4.8/+bug/__1360404 > > > Dunno about Ubuntu, but at least Ubuntu already changed it back. But > I guess there's no choice but to work around it anyway... Easiest > solution is probably just to drop the micro version out, back to the > granularity where it used to be. > > > Yes, I suppose so, but then we are almost at square one :-) Not really, the big deal about the change was to compare the version as a regular number instead of segmented comparison. Bringing in the micro-version was more of a side-effect than anything else, it just seemed simpler than having to cut out major.minor specifically. So no big loss, just mildly annoying workaround for upstream deviation :) - Panu -