From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 71CB9ADA4
 for <dev@dpdk.org>; Tue, 24 Feb 2015 11:39:02 +0100 (CET)
Received: by wggx12 with SMTP id x12so4351652wgg.6
 for <dev@dpdk.org>; Tue, 24 Feb 2015 02:39:02 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=hpBIhfDgyQuV8YsYQjTjBluUxnS/q9qjYYprcD7szyo=;
 b=RiFPL4iAVcnFSQLShSPBfJuY5mnr1Phm0dGAGjUm5jR1nQtoEDMh0tw7cexq4rZO2Q
 8fkcOF4e//8qGP1eEB+c+29xcWc/kDkKtK83Rl+D2kTzXkZeenINT8QUY7NmoIf3AY7G
 tT6ZSseia0kY71Unq+LvOrwDd2cTkqq13qU/3cyLS8i72UneBnBfwDXLDHyUQIxZ/sw5
 1E5AnuFjaIsbOfcW3S6awT3VJ5w+tUEJCN+VL3JLAp4On6211JEfVbcA0L84W/JsZXX+
 K6Q4RMD4fRuwBImx0zn9VrGSSjLw0/bE25MioO1IT3ACORbW3hq9wBoXvxatoU1EV7Ck
 /q7Q==
X-Gm-Message-State: ALoCoQkZLdRbo1j5DXP7gIMYeYj7OrdUnHrJqCAhgDIlN8itZI78edKePFdeo0mU1w/APQebb2fY
X-Received: by 10.181.27.168 with SMTP id jh8mr29247654wid.56.1424774342264;
 Tue, 24 Feb 2015 02:39:02 -0800 (PST)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id gm2sm19937235wib.5.2015.02.24.02.39.01
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 24 Feb 2015 02:39:01 -0800 (PST)
Message-ID: <54EC54C5.2060002@6wind.com>
Date: Tue, 24 Feb 2015 11:39:01 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.2.0
MIME-Version: 1.0
To: Pawel Wodkowski <pawelx.wodkowski@intel.com>, dev@dpdk.org
References: <1424700600-1765-1-git-send-email-pawelx.wodkowski@intel.com>
 <1424700600-1765-2-git-send-email-pawelx.wodkowski@intel.com>
In-Reply-To: <1424700600-1765-2-git-send-email-pawelx.wodkowski@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/5] rte_timer: fix invalid declaration of
 rte_timer_cb_t
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2015 10:39:02 -0000

Hi Pawel,

On 02/23/2015 03:09 PM, Pawel Wodkowski wrote:
> Declaration for function pointer should be
> typedef ret_type (*type_name)(args...)
> not
> typedef ret_type (type_name)(args...)
>
> although compiler treat both of them the same, the static analysis tool
> like klocwork complain about that.

Can you give some details about the reason why klocwork is
complaining?

Looking at the C11 standard, it seems that this syntax is
legal. Please see EXAMPLE 4, page 156 of:
http://www.open-std.org/JTC1/SC22/WG14/www/docs/n1570.pdf

Regards,
Olivier