DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: David Marchand <david.marchand@6wind.com>,
	 Panu Matilainen <pmatilai@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output
Date: Tue, 24 Feb 2015 12:14:40 +0100	[thread overview]
Message-ID: <54EC5D20.9090807@6wind.com> (raw)
In-Reply-To: <CALwxeUuEzJhxksjUuCNjDvpW=Z3BUb9Ac6H=GemeWKW+VVhP7w@mail.gmail.com>

Hi Panu, David,

On 02/24/2015 11:59 AM, David Marchand wrote:
>> >Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation
>> >on some versions of Debian and Ubuntu where gcc has been modified
>> >to only emit MAJOR.MINOR part of the version from 'gcc -dumpversion'.
>> >Drop the micro-version from gcc version comparisons to work around
>> >this, it wasn't being used for anything anyway.
>> >
>> >Signed-off-by: Panu Matilainen<pmatilai@redhat.com>
>
> ack (and works with my debian gcc).
>

One question: will it work with a version like with 2 digits
for major or minor like 4.10.0 or 10.0.0?
(or maybe it cannot happen with gcc naming conventions?)

Thanks,
Olivier

  reply	other threads:[~2015-02-24 11:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 10:46 Panu Matilainen
2015-02-24 10:59 ` David Marchand
2015-02-24 11:14   ` Olivier MATZ [this message]
2015-02-24 11:21     ` Panu Matilainen
2015-02-24 11:32   ` Thomas Monjalon
2015-02-24 13:34 ` Mcnamara, John
2015-02-24 14:13   ` Panu Matilainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EC5D20.9090807@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=pmatilai@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).