From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id A866DADB3 for ; Tue, 24 Feb 2015 12:14:41 +0100 (CET) Received: by wesx3 with SMTP id x3so24423090wes.7 for ; Tue, 24 Feb 2015 03:14:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=4tVgSgFdl8JrqCEJo/gXgiTQUg27EXFmM+SwvYRE5g4=; b=Y0+Nyovic/hLv0Hnx1vk8c0N4APMH52yxuH2GM3srx+rtHeGQHThgF5Xgu3euxQr3E LUykXVvevs/L85cxFEPXkl+c2Fo/KRdWl3tUeXUpEzvZKHx0yg3+8jQLmmYxAT7UXjPr 6xkr5qTVuhGX78obQk69o/T3YCqtRRPNXfAfYZ/Mmykeiey0pO1RuEJLIoik/n2pbeNd 51M09abVys/7xCEDYcsHTW/Y4EKGb9CLR682qm0S4FUmmkrPch9y4SQtxKG4ORtBWglX z9vanX1cP35Dy1qtqSxwlhnOGSPeUVBZXa+E7Yye4OyQtgzHVf+ElcmYAWgHaJcwz5HS TREA== X-Gm-Message-State: ALoCoQngenC6DyQyFyX6qnqNst0q30VUqNFtmxq4nNLLEyOTwZdlCQXqRtlvhV6sA0hIrKxCbf+N X-Received: by 10.194.77.99 with SMTP id r3mr31887989wjw.149.1424776481531; Tue, 24 Feb 2015 03:14:41 -0800 (PST) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id fa3sm20027705wib.17.2015.02.24.03.14.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Feb 2015 03:14:40 -0800 (PST) Message-ID: <54EC5D20.9090807@6wind.com> Date: Tue, 24 Feb 2015 12:14:40 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: David Marchand , Panu Matilainen References: <7529e243896615deb7d93e6080dfd2aced92bf86.1424774816.git.pmatilai@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 11:14:41 -0000 Hi Panu, David, On 02/24/2015 11:59 AM, David Marchand wrote: >> >Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation >> >on some versions of Debian and Ubuntu where gcc has been modified >> >to only emit MAJOR.MINOR part of the version from 'gcc -dumpversion'. >> >Drop the micro-version from gcc version comparisons to work around >> >this, it wasn't being used for anything anyway. >> > >> >Signed-off-by: Panu Matilainen > > ack (and works with my debian gcc). > One question: will it work with a version like with 2 digits for major or minor like 4.10.0 or 10.0.0? (or maybe it cannot happen with gcc naming conventions?) Thanks, Olivier