From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 29AD59AD5 for ; Tue, 24 Feb 2015 15:13:41 +0100 (CET) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1OEDdbA005721 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 24 Feb 2015 09:13:40 -0500 Received: from localhost.localdomain (vpn1-4-61.ams2.redhat.com [10.36.4.61]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1OEDcpi001193; Tue, 24 Feb 2015 09:13:39 -0500 Message-ID: <54EC8712.5060104@redhat.com> Date: Tue, 24 Feb 2015 16:13:38 +0200 From: Panu Matilainen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Mcnamara, John" References: <7529e243896615deb7d93e6080dfd2aced92bf86.1424774816.git.pmatilai@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc -dumpversion' output X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 14:13:41 -0000 On 02/24/2015 03:34 PM, Mcnamara, John wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen >> Sent: Tuesday, February 24, 2015 10:47 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] mk: Work around Debian/Ubuntu-specific 'gcc - >> dumpversion' output >> >> Commit 71f0ab1849b4fc3ca928deb566df12ca725ed150 broke compilation on some >> versions of Debian and Ubuntu where gcc has been modified to only emit >> MAJOR.MINOR part of the version from 'gcc -dumpversion'. >> Drop the micro-version from gcc version comparisons to work around this, >> it wasn't being used for anything anyway. >> >> -ifeq ($(shell test $(GCC_VERSION) -ge 440 && echo 1), 1) >> +ifeq ($(shell test $(GCC_VERSION) -ge 44 && echo 1), 1) > > Hi, > > I see this has been applied already but to me this version is less clear than the previous patch version. > > And are we sure we won't need the micro-version. If we do, to account for something broken in a point release of gcc, we will have to redo this patch again. Sure? I'm not enough of a fool to say yes to a question like that. I just know it hasn't been needed before, and it seems unlikely it will be needed later on either, gcc micro-version updates tend to be conservative. My only interest here was to fix the version comparisons in a way that makes gcc 5 naturally supported, and I dont really give a damn whether there's a micro-version involved or not :) If you feel strongly about it, send a patch. I'm not going to object. - Panu -