From: Vlad Zolotarov <vladz@cloudius-systems.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] : ixgbe: why bulk allocation is not used for a scattered Rx flow?
Date: Wed, 25 Feb 2015 11:40:36 +0200 [thread overview]
Message-ID: <54ED9894.3050409@cloudius-systems.com> (raw)
Hi, I have a question about the "scattered Rx" feature: why enabling it
disabled "bulk allocation" feature?
There is some unclear comment in the ixgbe_recv_scattered_pkts():
/*
* Descriptor done.
*
* Allocate a new mbuf to replenish the RX ring descriptor.
* If the allocation fails:
* - arrange for that RX descriptor to be the first one
* being parsed the next time the receive function is
* invoked [on the same queue].
*
* - Stop parsing the RX ring and return immediately.
*
* This policy does not drop the packet received in the RX
* descriptor for which the allocation of a new mbuf failed.
* Thus, it allows that packet to be later retrieved if
* mbuf have been freed in the mean time.
* As a side effect, holding RX descriptors instead of
* systematically giving them back to the NIC may lead to
* RX ring exhaustion situations.
* However, the NIC can gracefully prevent such situations
* to happen by sending specific "back-pressure" flow control
* frames to its peer(s).
*/
Why the same "policy" can't be done in the bulk-context allocation? -
Don't advance the RDT until u've refilled the ring. What do I miss here?
Another question is about the LRO feature - is there a reason why it's
not implemented? I've implemented the LRO support in ixgbe PMD to begin
with - I used a "scattered Rx" as a template and now I'm tuning it
(things like the stuff above).
Is there any philosophical reason why it hasn't been implemented in
*any* PMD so far? ;)
thanks,
vlad
next reply other threads:[~2015-02-25 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 9:40 Vlad Zolotarov [this message]
2015-02-25 11:02 ` Bruce Richardson
2015-02-25 16:46 ` Vlad Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ED9894.3050409@cloudius-systems.com \
--to=vladz@cloudius-systems.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).