Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function

[Tetsuya Mukawa <mukawa@igel.co.jp>]

On 2015/02/27 0:36, Mcnamara, John wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
>> Sent: Thursday, February 26, 2015 12:21 PM
>> To: Tetsuya Mukawa; Thomas Monjalon
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port
>> hotplug function
>>
>> The following commit introduced this issue:
>>
>>     $ git bisect good
>>     c743e50c475f73edf78e5ba26445d7c6ea217f40 is the first bad commit
>>     commit c743e50c475f73edf78e5ba26445d7c6ea217f40
> Hi,
>
> The above commit also has throws a warning with ICC:
>
>     lib/librte_pmd_null/rte_eth_null.c(47): error #83:
>         type qualifier specified more than once
>
>       static const char const *valid_arguments[] = {
>                         ^
>
>                         
> An earlier commit also throws a warning with ICC:
>              
>
>     lib/librte_pmd_null/rte_eth_null.c(47): error #83: 
>             type qualifier specified more than once
>
>             static const char const *valid_arguments[] = {
>             ^                        
>
> Commit:
>
>     92d94d3744d7760d8d5e490be810612cf4a9cfb0 is the first bad commit
>     commit 92d94d3744d7760d8d5e490be810612cf4a9cfb0
>     Author: Tetsuya Mukawa <mukawa@igel.co.jp>
>     Date:   Thu Feb 26 04:32:26 2015 +0900
>
>         ethdev: attach or detach port
>
>
> I applied the following patch to fix these issues, (in order to test with the HEAD). You can review them to see if they are valid and apply something similar:
>
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index bb94ccb..6ea7a17 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -433,7 +433,7 @@ static enum rte_eth_dev_type
>  rte_eth_dev_get_device_type(uint8_t port_id)
>  {
>         if (!rte_eth_dev_is_valid_port(port_id))
> -               return -1;
> +               return RTE_ETH_DEV_UNKNOWN;
>         return rte_eth_devices[port_id].dev_type;
>  }
>  
> diff --git a/lib/librte_pmd_null/rte_eth_null.c b/lib/librte_pmd_null/rte_eth_null.c
> index bb10276..3ef5842 100644
> --- a/lib/librte_pmd_null/rte_eth_null.c
> +++ b/lib/librte_pmd_null/rte_eth_null.c
> @@ -44,7 +44,7 @@
>  static unsigned default_packet_size = 64;
>  static unsigned default_packet_copy;
>  
> -static const char const *valid_arguments[] = {
> +static const char *valid_arguments[] = {
>         ETH_NULL_PACKET_SIZE_ARG,
>         ETH_NULL_PACKET_COPY_ARG,
>         NULL
>
>        
> John.

Hi Mcnamara and Stephen,

I appreciate for reporting.
I start checking all compile issues of null pmd.

Thanks,
Tetsuya