From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id D6D5E567F for ; Fri, 27 Feb 2015 02:31:59 +0100 (CET) Received: by pdjg10 with SMTP id g10so17247492pdj.1 for ; Thu, 26 Feb 2015 17:31:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=0OFnY31zpLh+RSW/gYLjjfz5v5EZWqH7jJr493Sn9gc=; b=J9rbZJBH/OjjW/y7Bv3043Wazm2cCEEc3HGtljibEfK0dJLHj2665pVdAurJA6bWXn /RIOPj+7tinx+Co2Jau/fBUEtgxow9NZhqEiI3TRR6eqDhz0g4tPV6BocgPhkjeBi6kp aHUmIstwwLFLLzbctIKgeBBhVmScT0wFmlgNmkqbbwgZCdAs9mo7Tvcd+DV7SPTATayx eE7hhX8pBqfTfrwty13yn+OU2T3QSTehtDiPwg2XoNbweeEojbm8duQrEOGQPbIfVq4d /lRM2Awc3Eh9qe/3W17Y9KHy0eVPSrpdnLuVI8tFio0k46ZTVvxG9Vyq39LfhhFeBqZ7 rupQ== X-Gm-Message-State: ALoCoQk9r/CvnPAgzTbDz/vRV9gepGSPHtnIBGGGioC746gfB93vLOo8XtH4SFq3PuHB/MIOiRLA X-Received: by 10.68.196.136 with SMTP id im8mr19459536pbc.125.1425000719065; Thu, 26 Feb 2015 17:31:59 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id ss9sm2091946pbc.96.2015.02.26.17.31.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Feb 2015 17:31:58 -0800 (PST) Message-ID: <54EFC909.6020401@igel.co.jp> Date: Fri, 27 Feb 2015 10:31:53 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Mcnamara, John" , Thomas Monjalon References: <1424414516-18609-1-git-send-email-mukawa@igel.co.jp> <1665241.NKrJfZ0zyg@xps13> <20150225164902.70f8abd6@urahara> <3153139.jQ5sXg5pox@xps13> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port hotplug function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 01:32:00 -0000 On 2015/02/27 0:36, Mcnamara, John wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John >> Sent: Thursday, February 26, 2015 12:21 PM >> To: Tetsuya Mukawa; Thomas Monjalon >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v11 2/2] librte_pmd_null: Support port >> hotplug function >> >> The following commit introduced this issue: >> >> $ git bisect good >> c743e50c475f73edf78e5ba26445d7c6ea217f40 is the first bad commit >> commit c743e50c475f73edf78e5ba26445d7c6ea217f40 > Hi, > > The above commit also has throws a warning with ICC: > > lib/librte_pmd_null/rte_eth_null.c(47): error #83: > type qualifier specified more than once > > static const char const *valid_arguments[] = { > ^ > > > An earlier commit also throws a warning with ICC: > > > lib/librte_pmd_null/rte_eth_null.c(47): error #83: > type qualifier specified more than once > > static const char const *valid_arguments[] = { > ^ > > Commit: > > 92d94d3744d7760d8d5e490be810612cf4a9cfb0 is the first bad commit > commit 92d94d3744d7760d8d5e490be810612cf4a9cfb0 > Author: Tetsuya Mukawa > Date: Thu Feb 26 04:32:26 2015 +0900 > > ethdev: attach or detach port > > > I applied the following patch to fix these issues, (in order to test with the HEAD). You can review them to see if they are valid and apply something similar: > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index bb94ccb..6ea7a17 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -433,7 +433,7 @@ static enum rte_eth_dev_type > rte_eth_dev_get_device_type(uint8_t port_id) > { > if (!rte_eth_dev_is_valid_port(port_id)) > - return -1; > + return RTE_ETH_DEV_UNKNOWN; > return rte_eth_devices[port_id].dev_type; > } > > diff --git a/lib/librte_pmd_null/rte_eth_null.c b/lib/librte_pmd_null/rte_eth_null.c > index bb10276..3ef5842 100644 > --- a/lib/librte_pmd_null/rte_eth_null.c > +++ b/lib/librte_pmd_null/rte_eth_null.c > @@ -44,7 +44,7 @@ > static unsigned default_packet_size = 64; > static unsigned default_packet_copy; > > -static const char const *valid_arguments[] = { > +static const char *valid_arguments[] = { > ETH_NULL_PACKET_SIZE_ARG, > ETH_NULL_PACKET_COPY_ARG, > NULL > > > John. Hi Mcnamara and Stephen, I appreciate for reporting. I start checking all compile issues of null pmd. Thanks, Tetsuya