From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id BC0C53B5 for ; Wed, 4 Mar 2015 04:34:15 +0100 (CET) Received: by pabrd3 with SMTP id rd3so5775566pab.5 for ; Tue, 03 Mar 2015 19:34:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=ubyDMM3pCHc9FP8vR33BK1P+cF9nJUr1U9sMT7bX80w=; b=b7jCDXgErCJvzWgeTW90ScLdDEogeBIcv2jnMJo23AcjwLyUjHnVw3gFfBk0i/9Zu/ 1jrm4FZYnH8bXpnCzfbnJKWfu9yB3IBSGrszujk7mtFtuv+BehqIBXy5M+N1hLYrCQJC /5XMEktj82O3J/ih4JU6v5pn6142a8hxRsiGhXBsLSGUGhmcWuNPTj15x03U1WPhy14y VvWt2OM+8OydxXlagnn2okNmDK6ofKZ4gRKzZS+xPE/GA5yo8HKkvn9gS+gXlYhMW8WI cQEo3IhsOD5677wItsxy+1/xfI1i+ibiqM7doNL0OZqRbzZfYljbpx7mNTdix9VqaBpg H9gQ== X-Gm-Message-State: ALoCoQlDnrsg5B4Vh+ZCz3h5gr4OQvi52VNX6nCQ7BubHrQZQUUAK/O8c0/PxKQJWFE0QAPzvj3W X-Received: by 10.68.244.2 with SMTP id xc2mr3109449pbc.45.1425440055020; Tue, 03 Mar 2015 19:34:15 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id hf8sm2387335pbc.21.2015.03.03.19.34.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Mar 2015 19:34:14 -0800 (PST) Message-ID: <54F67D33.6010104@igel.co.jp> Date: Wed, 04 Mar 2015 12:34:11 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Bruce Richardson References: <54F3DD5E.1070307@igel.co.jp> <20150302102225.GB8520@bricha3-MOBL3> In-Reply-To: <20150302102225.GB8520@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Build failure on FreeBSD-10.1-RELEASE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 03:34:16 -0000 On 2015/03/02 19:22, Bruce Richardson wrote: > On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wrote: >> Hi, >> >> I got a error while building master branch on FreeBSD. >> Here is a log. >> >> $ gmake T=x86_64-native-bsdapp-clang config >> cc: error: unknown argument: '-fdirectives-only' >> cp: /usr/home/mukawa/work/dpdk/build/.config_tmp: No such file or directory >> cp: /usr/home/mukawa/work/dpdk/build/.config_tmp: No such file or directory >> gmake[3]: Nothing to be done for 'depdirs'. >> Configuration done >> >> >> Here is log came from 'uname' >> >> $ uname -a >> FreeBSD eris.hq.igel.co.jp 10.1-RELEASE FreeBSD 10.1-RELEASE #0 r274401: >> Tue Nov 11 21:02:49 UTC 2014 >> >> >> I've tried to remove '-fdirectives-only' from mk/rte.sdkconfig.mk like >> below. >> With the fixing, It seems I can compile and run testpmd. >> (Obviously, we should not merge below patch, but I've done just for testing) >> >> diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk >> index d43c430..f8d95b1 100644 >> --- a/mk/rte.sdkconfig.mk >> +++ b/mk/rte.sdkconfig.mk >> @@ -75,7 +75,7 @@ else >> $(RTE_OUTPUT)/.config: $(RTE_CONFIG_TEMPLATE) FORCE | $(RTE_OUTPUT) >> $(Q)if [ "$(RTE_CONFIG_TEMPLATE)" != "" -a -f >> "$(RTE_CONFIG_TEMPLATE)" ]; then \ >> $(CPP) -undef -P -x assembler-with-cpp \ >> - -fdirectives-only -ffreestanding \ >> + -ffreestanding \ >> -o $(RTE_OUTPUT)/.config_tmp $(RTE_CONFIG_TEMPLATE) ; \ >> if ! cmp -s $(RTE_OUTPUT)/.config_tmp >> $(RTE_OUTPUT)/.config; then \ >> cp $(RTE_OUTPUT)/.config_tmp >> $(RTE_OUTPUT)/.config ; \ >> >> >> Also, I've checked /usr/ports/net/dpdk, and found below line. >> (It seems above ports dpdk package is based on DPDK-1.8.) >> >> >> $(CPP) -undef -P -x assembler-with-cpp \ >> -ffreestanding \ >> -o $(RTE_OUTPUT)/.config_tmp $(RTE_CONFIG_TEMPLATE) ; \ >> >> So, I guess we should not add '-fdirectives-only' for flags of $(CPP) >> for BSD system like dpdk package of ports. >> >> Thanks, >> Tetsuya >> > Yes, that is correct. In most cases I have tested, the extra flag only gives a > warning but it appears its now an error. We should conditionally include or > omit the flag for BSD vs Linux, I think. > > /Bruce Hi Bruce, It seems we cannot use CONFIG_RTE_EXEC_ENV_LINUXAPP/BSDAPP definition here. Now I am looking for other way to check target OS. Is it not so good to use $(T) definition value here? Thanks, Tetsuya