From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 4ABD73B5 for ; Wed, 4 Mar 2015 08:59:40 +0100 (CET) Received: by widex7 with SMTP id ex7so28386053wid.0 for ; Tue, 03 Mar 2015 23:59:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=kaOnrnwtN/e/8hK4BsEYTd1NyJN+VtDu68Lpkrn/Fvo=; b=jtzhRxWqZVLz/3RURqkqlBq1JT1JoxD4/hjOa+elzOXnJwbmYkFBt40CEtA/tqbaB9 G3mafA8OzG8Yr26CsD4daCVmr2uR59eRlBSL/gODksVuvUUgwNLS/91KxyPAX42MROH3 8UcaeSg2w1vh9Fwsd9Y41zjhfRk2Lsj4C16I1LFT7Qo3jde58b7lTGT/Zdf+p/N/oeCr WOupJO6JXrGkSmnTcCYeD0DBmkhyVegJLeTVfcqBfiuBWzEDfUARhmvkKiFA0HloPPg7 w/Dun/Eo4QWx+dy2k5SbgMZXsFXXC8659OVIacym1g3folqT2y1U9BxkFnBasdI1Cd15 vCwA== X-Gm-Message-State: ALoCoQk4VqehKeElJb+SK3RsB1kQ+m1Hfz3il/gqSk1uSiIhw02O03zY9fLbm1AVUu8KBEKe3QzV X-Received: by 10.194.170.193 with SMTP id ao1mr5456276wjc.52.1425455980186; Tue, 03 Mar 2015 23:59:40 -0800 (PST) Received: from [10.0.0.2] ([109.65.117.109]) by mx.google.com with ESMTPSA id dj5sm4748518wjb.28.2015.03.03.23.59.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Mar 2015 23:59:39 -0800 (PST) Message-ID: <54F6BB6A.5080205@cloudius-systems.com> Date: Wed, 04 Mar 2015 09:59:38 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Stephen Hemminger References: <1425412123-5227-1-git-send-email-vladz@cloudius-systems.com> <1425412123-5227-6-git-send-email-vladz@cloudius-systems.com> <20150303163638.118d630e@urahara> In-Reply-To: <20150303163638.118d630e@urahara> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 07:59:40 -0000 On 03/04/15 02:36, Stephen Hemminger wrote: > On Tue, 3 Mar 2015 21:48:43 +0200 > Vlad Zolotarov wrote: > >> - Only x540 and 82599 devices support LRO. >> - Add the appropriate HW configuration. >> - Add RSC aware rx_pkt_burst() handlers: >> - Implemented bulk allocation and non-bulk allocation versions. >> - Add LRO-specific fields to rte_eth_rxmode, to rte_eth_dev_data >> and to igb_rx_queue. >> - Use the appropriate handler when LRO is requested. >> >> Signed-off-by: Vlad Zolotarov > Checkpatch warnings (edited to remove ones that should be ok) I was unaware that checkpatch rules apply here - at least looking at the current code it looks like it... ;) But I'm all for it! I'll fix all the issues and respin. Thanks. > > > WARNING: 'recieved' may be misspelled - perhaps 'received'? > #196: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1426: > + * @rx_pkts table of recieved packets > > WARNING: Missing a blank line after declarations > #223: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1453: > + struct igb_rx_queue *rxq = rx_queue; > + volatile union ixgbe_adv_rx_desc *rx_ring = rxq->rx_ring; > > > > WARNING: labels should not be indented > #246: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1476: > + next_desc: > > WARNING: quoted string split across lines > #285: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1515: > + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u rx_id=%u " > + "staterr=0x%x data_len=%u", > > WARNING: quoted string split across lines > #293: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1523: > + PMD_RX_LOG(DEBUG, "RX mbuf alloc failed " > + "port_id=%u queue_id=%u", > > WARNING: Missing a blank line after declarations > #302: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1532: > + uint16_t next_rdt = rxq->rx_free_trigger; > + if (!ixgbe_rx_alloc_bufs(rxq, false)) { > > WARNING: quoted string split across lines > #309: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1539: > + PMD_RX_LOG(DEBUG, "RX bulk alloc failed " > + "port_id=%u queue_id=%u", > > ERROR: code indent should use tabs where possible > #350: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1580: > + rxm->data_off = RTE_PKTMBUF_HEADROOM;$ > > WARNING: please, no spaces at the start of a line > #350: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1580: > + rxm->data_off = RTE_PKTMBUF_HEADROOM;$ > > WARNING: quoted string split across lines > #452: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1682: > + PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u rx_tail=%u " > + "nb_hold=%u nb_rx=%u", > > WARNING: quoted string split across lines > #536: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2580: > + PMD_INIT_LOG(DEBUG, "sw_ring=%p sw_rsc_ring=%p hw_ring=%p " > + "dma_addr=0x%"PRIx64, > > WARNING: Possible switch case/default not preceeded by break or fallthrough comment > #617: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:3926: > + default: > > WARNING: quoted string split across lines > #648: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:3966: > + PMD_INIT_LOG(CRIT, "LRO is requested on HW that doesn't " > + "support it"); > > WARNING: quoted string split across lines > #693: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4022: > + PMD_INIT_LOG(CRIT, "LRO can't be enabled when HW CRC " > + "is disabled"); > > WARNING: quoted string split across lines > #711: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4084: > + PMD_INIT_LOG(INFO, "split_hdr_size less than " > + "128 bytes (%d)!", > > WARNING: quoted string split across lines > #835: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4267: > + PMD_INIT_LOG(INFO, "LRO is requested. Using a bulk " > + "allocation version"); > > WARNING: quoted string split across lines > #840: FILE: lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4272: > + PMD_INIT_LOG(INFO, "LRO is requested. Using a single " > + "allocation version"); > >