From: Avi Kivity <avi@cloudius-systems.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Vlad Zolotarov <vladz@cloudius-systems.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support
Date: Wed, 04 Mar 2015 10:05:34 +0200 [thread overview]
Message-ID: <54F6BCCE.80602@cloudius-systems.com> (raw)
In-Reply-To: <20150303163359.2975c702@urahara>
On 03/04/2015 02:33 AM, Stephen Hemminger wrote:
> On Tue, 3 Mar 2015 21:48:43 +0200
> Vlad Zolotarov <vladz@cloudius-systems.com> wrote:
>
>> + * TODO:
>> + * - Get rid of "volatile" crap and let the compiler do its
>> + * job.
>> + * - Use the proper memory barrier (rte_rmb()) to ensure the
>> + * memory ordering below.
> This comment screams "this is broken".
> Why not get proper architecture independent barriers in DPDK first.
C11 has arch independent memory barriers, so this can be as simple as
-std=gnu11 (default in gcc 5, anyway).
Not only do we get the barriers for free, but they are also properly
integrated with the compiler, so for example a release barrier won't
stop the compiler from hoisting a later accesses to before the store, or
cause spurious reloads, due to the memory clobber.
next prev parent reply other threads:[~2015-03-04 8:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 19:48 [dpdk-dev] [PATCH v1 0/5]: Add LRO support to ixgbe PMD Vlad Zolotarov
2015-03-03 19:48 ` [dpdk-dev] [PATCH v1 1/5] ixgbe: Cleanups Vlad Zolotarov
2015-03-03 19:48 ` [dpdk-dev] [PATCH v1 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices Vlad Zolotarov
2015-03-03 19:48 ` [dpdk-dev] [PATCH v1 3/5] ixgbe: Code refactoring Vlad Zolotarov
2015-03-03 19:48 ` [dpdk-dev] [PATCH v1 4/5] common_linuxapp: Added CONFIG_RTE_ETHDEV_LRO_SUPPORT option Vlad Zolotarov
2015-03-03 19:48 ` [dpdk-dev] [PATCH v1 5/5] ixgbe: Add LRO support Vlad Zolotarov
2015-03-04 0:33 ` Stephen Hemminger
2015-03-04 7:24 ` Vlad Zolotarov
2015-03-04 0:33 ` Stephen Hemminger
2015-03-04 7:57 ` Vlad Zolotarov
2015-03-04 18:54 ` Stephen Hemminger
2015-03-05 9:36 ` Vlad Zolotarov
2015-03-04 8:05 ` Avi Kivity [this message]
2015-03-04 0:34 ` Stephen Hemminger
2015-03-04 7:57 ` Vlad Zolotarov
2015-03-04 0:36 ` Stephen Hemminger
2015-03-04 7:59 ` Vlad Zolotarov
2015-03-04 18:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F6BCCE.80602@cloudius-systems.com \
--to=avi@cloudius-systems.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=vladz@cloudius-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).