From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 491D95683 for ; Wed, 4 Mar 2015 10:08:21 +0100 (CET) Received: by wggx12 with SMTP id x12so45147867wgg.11 for ; Wed, 04 Mar 2015 01:08:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=2yoxQZ8eFt24psTdbMSiLpAT1hQlWwaV9nzZYWA+JtY=; b=KwiDNssQ2fEX2EiDKE/6LZXuXFcbWdc8cBhxedYOcOegJfEggFPFOajb7VhBPm36bY g+TNshLmBRHMEXnX4MquHvVC7MHo4ByPWE5evS7cqbOhtELm4AnVU8GsN3/LLYNp+JSR M2xApFAP3jznEU0RCqw+0SIe1OTtVxfV7MJQ9kVE/vwblT+yzGkFGd+HQD5zOMaCdra6 ciNIZ6lA8JKXsVKH7UKj0EfRva9xuYwyZTNnwwGCrZVLJX0gBGh6djSIKWYOKZqDEesr livoF8YemZ+hrUW5Qdxukqmu0f4Kp/tv2+7d18E5Y17YXN//YLL725dQBI03gRlOrbe1 /EiA== X-Gm-Message-State: ALoCoQkFhxnScWdQaFMp0beGMCflX81LyCdnT/Oqcd+Sf+xSEaPrrlICOgk/p/3VPHDZDT9NoR9C X-Received: by 10.181.27.201 with SMTP id ji9mr23834820wid.20.1425460101121; Wed, 04 Mar 2015 01:08:21 -0800 (PST) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id hj10sm4972205wjc.48.2015.03.04.01.08.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2015 01:08:20 -0800 (PST) Message-ID: <54F6CB84.2050202@6wind.com> Date: Wed, 04 Mar 2015 10:08:20 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Keith Wiles , dev@dpdk.org References: <1425142563-27185-1-git-send-email-keith.wiles@intel.com> In-Reply-To: <1425142563-27185-1-git-send-email-keith.wiles@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] External app builds need to locate common make fragments and includes. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 09:08:21 -0000 Hi Keith, On 02/28/2015 05:56 PM, Keith Wiles wrote: > When building an external application like Pktgen and using the proper > makefile fragments rte.extXYZ.mk NOT rte.XYZ.mk files as you would > use with example applications in the same RTE_SDK directory the rte.extXYZ.mk > files are missing some defines/includes. > > 1 - Add missing tests for RTE_SDK/RTE_TARGET not defined code. > 2 - The build of external applications are forced to be verbose ouput > as the Q=@ define is not present. > 3 - Missing include of target/generic/rte.vars.mk file which includes > the information to locate the rte_config.h and other DPDK include > files. > > A patch like this one was submitted before and was rejected because it > seemed it was not required, because target/generic/rte.vars.mk already > included by rte.vars.mk. > > This is not the cause for external applications like Pktgen which are > built outside of the RTE_SDK directory and only include the rte.extXYZ.mk > makefile fragments. I still not understand what is your problem. If you take an example from dpdk, let's say examples/l2fwd. cd test # compile dpdk git clone http://dpdk.org/git/dpdk cd dpdk DPDK=${PWD} make -j8 install T=x86_64-native-linuxapp-gcc cd .. # copy l2fwd in an external directory cp -r dpdk/examples/l2fwd . cd l2fwd # build it make RTE_TARGET=x86_64-native-linuxapp-gcc RTE_SDK=${DPDK} So if you use a Makefile similar to l2fwd, I think it should work. As I explained in [1], you need to include "rte.vars.mk" at the beginning of the Makefile, not "rte.extvars.mk". But you will use "rte.extapp.mk" at the end, like in l2fwd Makefile. Regards, Olivier [1] http://dpdk.org/ml/archives/dev/2015-February/013301.html