From: Olivier MATZ <olivier.matz@6wind.com>
To: Marc Sune <marc.sune@bisdn.de>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: add support for gdb debug info generation
Date: Wed, 04 Mar 2015 10:44:33 +0100 [thread overview]
Message-ID: <54F6D401.3030009@6wind.com> (raw)
In-Reply-To: <54F5B6CD.7090209@bisdn.de>
Hi Marc,
On 03/03/2015 02:27 PM, Marc Sune wrote:
>
> On 03/03/15 14:03, Bruce Richardson wrote:
>> On Tue, Mar 03, 2015 at 01:56:19PM +0100, Marc Sune wrote:
>> [...]
>> I believe that the global option of overriding the CFLAGS is already
>> sufficiently
>> covered - including being documented in programmers guide - by
>> EXTRA_CFLAGS.
>
> To be honest, I tried EXTRA_CFLAGS at some point in time (probably 1.5
> or 1.6, but maybe not stable releases) and it did not work, so I ended
> up doing it manually, and never tried again.
>
> It does work now with CFLAGS, I didn't try LDFLAGS, but it does not for
> EXTRA_CPPFLAGS apparently (unless I made some stupid mistake):
>
> marc@dpdk:~/dpdk$ git diff
> diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c
> index 4e70fa0..4a1e538 100644
> --- a/lib/librte_kni/rte_kni.c
> +++ b/lib/librte_kni/rte_kni.c
> @@ -61,6 +61,10 @@
>
> #define KNI_MEM_CHECK(cond) do { if (cond) goto kni_fail; } while (0)
>
> +#ifdef TEST_CPPFLAGS
> + #error TEST_CPPFLAGS defined
> +#endif
> +
> /**
> * KNI context
> */
>
> marc@dpdk:~/dpdk$ export EXTRA_CPPFLAGS='-DTEST_CPPFLAGS'
> marc@dpdk:~/dpdk$ make install T=x86_64-native-linuxapp-gcc
> ...
> Build complete
The reason why it does not work is described in the documentation:
./doc/guides/prog_guide/build_app.rst:* CPPFLAGS: The flags to use to
provide flags to the C preprocessor (only useful when assembling .S files)
./doc/guides/prog_guide/dev_kit_build_system.rst:* CPPFLAGS: Flags to
use to give flags to C preprocessor (only useful when assembling .S files).
./doc/guides/prog_guide/dev_kit_build_system.rst:* EXTRA_CPPFLAGS: The
content of this variable is appended after CPPFLAGS when using a C
preprocessor on assembly files.
I think your test would work with EXTRA_CFLAGS.
I don't say it's the proper behavior, but at least it's coherent with
the documentation.
Regards,
Olivier
next prev parent reply other threads:[~2015-03-04 9:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 17:31 Cyril Chemparathy
2014-04-04 9:57 ` Ananyev, Konstantin
2015-02-22 11:51 ` Marc Sune
2015-03-02 17:32 ` Marc Sune
2015-03-03 9:33 ` Bruce Richardson
2015-03-03 12:19 ` Marc Sune
2015-03-03 12:40 ` Panu Matilainen
2015-03-03 12:56 ` Marc Sune
2015-03-03 13:03 ` Bruce Richardson
2015-03-03 13:27 ` Marc Sune
2015-03-04 9:44 ` Olivier MATZ [this message]
2015-03-03 13:31 ` Ananyev, Konstantin
2015-03-03 14:39 ` Marc Sune
2015-03-03 16:24 ` Ananyev, Konstantin
2015-03-03 13:32 ` Thomas Monjalon
2015-06-19 21:29 Cyril Chemparathy
2015-06-22 7:44 ` Gonzalez Monroy, Sergio
2015-06-22 7:56 ` Simon Kågström
2015-06-23 7:39 ` Gonzalez Monroy, Sergio
2015-06-23 7:47 ` Thomas Monjalon
2015-06-23 10:08 ` Simon Kågström
2015-06-22 16:41 ` Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F6D401.3030009@6wind.com \
--to=olivier.matz@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=marc.sune@bisdn.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).