From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 6672E5A76 for ; Thu, 5 Mar 2015 08:08:48 +0100 (CET) Received: by pdbnh10 with SMTP id nh10so40454946pdb.3 for ; Wed, 04 Mar 2015 23:08:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=g2E6OXahpcJzQhideibYe4Nop5o9Y9pcYN9JzLvPdmo=; b=ZK99uz6RJTp0rku+2T+2owgeoM08T0O0wVPyaTEsDKhL6/SD+DIHkenjdZEkRiDsnp lB3cwxn7lQD2BluwFV8C9aYyxPmnnDvJSJBmTnEe/nns0MvsRc/ggqxo+igUnxyQJ8q3 iniovJ78/ttMrdLXReRPMnv6MG9enWZUDeXUsu9ZgBpjSvvT+n4rKCyZ0BDMz3p58z6n z49eWC/rLpsENjAxlkncfgvT4EIOK7B/DikldkAo9sdEWpjWlcsg6bBH0dCBSYGLQ4uD q7tomaBQEmlUUYzPH7Xdl9Eu30beQafGT1x3Xu0dX478pyeVd4R5Tyx0pE0x4MfnQEDs KRGw== X-Gm-Message-State: ALoCoQlJCy+MD7Zs99njgM8YNHB4I6YcWyme0LOZdRcbatLvc3fFfaaOSvbjr8PsHE9sOhTNP0Lh X-Received: by 10.70.90.9 with SMTP id bs9mr12914980pdb.137.1425539327605; Wed, 04 Mar 2015 23:08:47 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id zd14sm6021020pab.20.2015.03.04.23.08.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2015 23:08:37 -0800 (PST) Message-ID: <54F800F2.2090104@igel.co.jp> Date: Thu, 05 Mar 2015 16:08:34 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Bruce Richardson , Olivier MATZ References: <54F3DD5E.1070307@igel.co.jp> <20150302102225.GB8520@bricha3-MOBL3> <54F67D33.6010104@igel.co.jp> <54F6D15A.1010900@6wind.com> <20150304101510.GB1468@bricha3-MOBL3> In-Reply-To: <20150304101510.GB1468@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Build failure on FreeBSD-10.1-RELEASE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2015 07:08:48 -0000 On 2015/03/04 19:15, Bruce Richardson wrote: > On Wed, Mar 04, 2015 at 10:33:14AM +0100, Olivier MATZ wrote: >> Hi Tetsuya, Hi Bruce, >> >> On 03/04/2015 04:34 AM, Tetsuya Mukawa wrote: >>> On 2015/03/02 19:22, Bruce Richardson wrote: >>>> On Mon, Mar 02, 2015 at 12:47:42PM +0900, Tetsuya Mukawa wrote: >>>>> Hi, >>>>> >>>>> I got a error while building master branch on FreeBSD. >>>>> Here is a log. >>>>> >>>>> $ gmake T=3Dx86_64-native-bsdapp-clang config >>>>> cc: error: unknown argument: '-fdirectives-only' >>>>> cp: /usr/home/mukawa/work/dpdk/build/.config_tmp: No such file or d= irectory >>>>> cp: /usr/home/mukawa/work/dpdk/build/.config_tmp: No such file or d= irectory >>>>> gmake[3]: Nothing to be done for 'depdirs'. >>>>> Configuration done >>>>> >>>>> >>>>> Here is log came from 'uname' >>>>> >>>>> $ uname -a >>>>> FreeBSD eris.hq.igel.co.jp 10.1-RELEASE FreeBSD 10.1-RELEASE #0 r27= 4401: >>>>> Tue Nov 11 21:02:49 UTC 2014 >>>>> >>>>> >>>>> I've tried to remove '-fdirectives-only' from mk/rte.sdkconfig.mk l= ike >>>>> below. >>>>> With the fixing, It seems I can compile and run testpmd. >>>>> (Obviously, we should not merge below patch, but I've done just for= testing) >>>>> >>>>> diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk >>>>> index d43c430..f8d95b1 100644 >>>>> --- a/mk/rte.sdkconfig.mk >>>>> +++ b/mk/rte.sdkconfig.mk >>>>> @@ -75,7 +75,7 @@ else >>>>> $(RTE_OUTPUT)/.config: $(RTE_CONFIG_TEMPLATE) FORCE | $(RTE_OUTPUT= ) >>>>> $(Q)if [ "$(RTE_CONFIG_TEMPLATE)" !=3D "" -a -f >>>>> "$(RTE_CONFIG_TEMPLATE)" ]; then \ >>>>> $(CPP) -undef -P -x assembler-with-cpp \ >>>>> - -fdirectives-only -ffreestanding \ >>>>> + -ffreestanding \ >>>>> -o $(RTE_OUTPUT)/.config_tmp $(RTE_CONFIG_TEMPLATE)= ; \ >>>>> if ! cmp -s $(RTE_OUTPUT)/.config_tmp >>>>> $(RTE_OUTPUT)/.config; then \ >>>>> cp $(RTE_OUTPUT)/.config_tmp >>>>> $(RTE_OUTPUT)/.config ; \ >>>>> >>>>> >>>>> Also, I've checked /usr/ports/net/dpdk, and found below line. >>>>> (It seems above ports dpdk package is based on DPDK-1.8.) >>>>> >>>>> >>>>> $(CPP) -undef -P -x assembler-with-cpp \ >>>>> -ffreestanding \ >>>>> -o $(RTE_OUTPUT)/.config_tmp $(RTE_CONFIG_TEMPLATE) = ; \ >>>>> >>>>> So, I guess we should not add '-fdirectives-only' for flags of $(CP= P) >>>>> for BSD system like dpdk package of ports. >>>>> >>>>> Thanks, >>>>> Tetsuya >>>>> >>>> Yes, that is correct. In most cases I have tested, the extra flag on= ly gives a >>>> warning but it appears its now an error. We should conditionally inc= lude or >>>> omit the flag for BSD vs Linux, I think. >>>> >>>> /Bruce >>> Hi Bruce, >>> >>> It seems we cannot use CONFIG_RTE_EXEC_ENV_LINUXAPP/BSDAPP definition= here. >>> Now I am looking for other way to check target OS. >>> Is it not so good to use $(T) definition value here? >> Indeed, it seems that the -fdirectives-only option does not exist in >> freebsd. This is probably because the default cpp is not GNU cpp: >> >> On my version, I have: >> FreeBSD clang version 3.3 (tags/RELEASE_33/final 183502) 20130610 >> Target: x86_64-unknown-freebsd10.0 >> Thread model: posix >> >> To decide whether using the option, we could check the return value of= >> cpp -fdirectives-only /dev/null > /dev/null 2>/dev/null It=92s a great idea. >> But I don't really think it's an issue to remove the option for all >> OSes. In my opinion, expanding macros when parsing the config files >> won't add any issue, and it's probably better to have no differences >> between FreeBSD and Linux. >> >> Regards, >> Olivier >> > +1=20 > I was just going to suggest that this morning! :-) Thanks for suggestions. I will send a patch that just removes '-fdirectives-only'. Thanks, Tetsuya