From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgw.gov.kz (mgw.gov.kz [89.218.88.242]) by dpdk.org (Postfix) with ESMTP id 585665A6A for ; Thu, 5 Mar 2015 18:04:34 +0100 (CET) Received: from mgw.gov.kz (mx.ctsat.kz [178.89.4.95]) by mgw.gov.kz with ESMTP id t25H4X8l018553-t25H4X8m018553; Thu, 5 Mar 2015 23:04:33 +0600 Received: from EXCASHUB1.rgp.local (192.168.40.51) by EdgeForefront.rgp.local (192.168.40.59) with Microsoft SMTP Server (TLS) id 14.2.247.3; Thu, 5 Mar 2015 23:02:52 +0600 Received: from [192.168.35.15] (192.168.35.15) by excashub1.rgp.local (192.168.40.48) with Microsoft SMTP Server (TLS) id 14.2.247.3; Thu, 5 Mar 2015 23:04:25 +0600 Message-ID: <54F88C35.3070602@sts.kz> Date: Thu, 5 Mar 2015 23:02:45 +0600 From: Yerden Zhumabekov User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Qiu , References: <1425561339-13300-2-git-send-email-michael.qiu@intel.com> <1425574530-16019-1-git-send-email-michael.qiu@intel.com> In-Reply-To: <1425574530-16019-1-git-send-email-michael.qiu@intel.com> Content-Type: text/plain; charset="windows-1251" Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.35.15] X-FEAS-SYSTEM-WL: e_zhumabekov@sts.kz Subject: Re: [dpdk-dev] [PATCH 1/3 v2] librte_hash: Fix unsupported instruction `crc32' in i686 platform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2015 17:04:34 -0000 Acked-by: Yerden Zhumabekov 05.03.2015 22:55, Michael Qiu пишет: > CC rte_hash.o > Error: unsupported instruction `crc32' > > The root cause is that i686 platform does not support 'crc32q' > Need make it only available in x86_64 platform > > Signed-off-by: Michael Qiu > --- > v2 --> v1: > Make crc32 instruction only works in X86 platform > lib/librte_hash/rte_hash_crc.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/rte_hash_crc.h > index d28bb2a..c0a789e 100644 > --- a/lib/librte_hash/rte_hash_crc.h > +++ b/lib/librte_hash/rte_hash_crc.h > @@ -364,6 +364,7 @@ crc32c_2words(uint64_t data, uint32_t init_val) > return crc; > } > > +#if defined RTE_ARCH_I686 || defined RTE_ARCH_X86_64 > static inline uint32_t > crc32c_sse42_u32(uint32_t data, uint32_t init_val) > { > @@ -373,7 +374,9 @@ crc32c_sse42_u32(uint32_t data, uint32_t init_val) > : [data] "rm" (data)); > return init_val; > } > +#endif > > +#ifdef RTE_ARCH_X86_64 > static inline uint32_t > crc32c_sse42_u64(uint64_t data, uint64_t init_val) > { > @@ -383,7 +386,9 @@ crc32c_sse42_u64(uint64_t data, uint64_t init_val) > : [data] "rm" (data)); > return init_val; > } > +#endif > > +#if defined RTE_ARCH_I686 || defined RTE_ARCH_X86_64 > static inline uint32_t > crc32c_sse42_u64_mimic(uint64_t data, uint64_t init_val) > { > @@ -397,6 +402,7 @@ crc32c_sse42_u64_mimic(uint64_t data, uint64_t init_val) > init_val = crc32c_sse42_u32(d.u32[1], init_val); > return init_val; > } > +#endif > > #define CRC32_SW (1U << 0) > #define CRC32_SSE42 (1U << 1) > @@ -455,8 +461,10 @@ rte_hash_crc_init_alg(void) > static inline uint32_t > rte_hash_crc_4byte(uint32_t data, uint32_t init_val) > { > +#if defined RTE_ARCH_I686 || defined RTE_ARCH_X86_64 > if (likely(crc32_alg & CRC32_SSE42)) > return crc32c_sse42_u32(data, init_val); > +#endif > > return crc32c_1word(data, init_val); > } > @@ -476,11 +484,15 @@ rte_hash_crc_4byte(uint32_t data, uint32_t init_val) > static inline uint32_t > rte_hash_crc_8byte(uint64_t data, uint32_t init_val) > { > +#ifdef RTE_ARCH_X86_64 > if (likely(crc32_alg == CRC32_SSE42_x64)) > return crc32c_sse42_u64(data, init_val); > +#endif > > +#if defined RTE_ARCH_I686 || defined RTE_ARCH_X86_64 > if (likely(crc32_alg & CRC32_SSE42)) > return crc32c_sse42_u64_mimic(data, init_val); > +#endif > > return crc32c_2words(data, init_val); > } -- Sincerely, Yerden Zhumabekov State Technical Service Astana, KZ