DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tomas Vestelind <tomas.vestelind@gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] hash: added rte_hash_clear that clears all keys
Date: Fri, 06 Mar 2015 13:02:56 +0100
Message-ID: <54F99770.5040201@gmail.com> (raw)
In-Reply-To: <20150306111025.GA9352@bricha3-MOBL3>

Hi Bruce!

Oh yea, this patch is quite old :)

I'm currently not working actively with DPDK. If no one else wants to do 
it, I could do the update and add a unit test

/Tomas

On 2015-03-06 12:10, Bruce Richardson wrote:
> On Tue, Aug 12, 2014 at 11:47:57PM +0200, Tomas Vestelind wrote:
>> I added rte_hash_clear which clear the map from all previously added
>> keys.
>>
> This patch is now quite old and needs an update to add the new API to the
> rte_hash_version.map. A unit test for the new function would also be good to
> have. Otherwise patch content looks ok. Is an updated V2 planned?
>
> Regards,
> /Bruce
>
>> Signed-off-by: Tomas Vestelind <tomas.vestelind at gmail.com>
>> ---
>>   lib/librte_hash/rte_hash.c |   14 ++++++++++++++
>>   lib/librte_hash/rte_hash.h |   10 ++++++++++
>>   2 files changed, 24 insertions(+)
>>
>> diff --git a/lib/librte_hash/rte_hash.c b/lib/librte_hash/rte_hash.c
>> index 2108c4f..917a6c1 100644
>> --- a/lib/librte_hash/rte_hash.c
>> +++ b/lib/librte_hash/rte_hash.c
>> @@ -507,3 +507,17 @@ rte_hash_keys(const struct rte_hash *h, void *keys)
>>   
>>       return found_keys;
>>   }
>> +
>> +void
>> +rte_hash_clear(const struct rte_hash *h)
>> +{
>> +    unsigned int bucket, entry;
>> +
>> +    /* Clear all entries by invalidating each signature */
>> +    for (bucket = 0; bucket < h->num_buckets; bucket++) {
>> +        hash_sig_t *sig = get_sig_tbl_bucket(h, bucket);
>> +        for (entry = 0; entry < h->bucket_entries; entry++) {
>> +            sig[entry] = NULL_SIGNATURE;
>> +        }
>> +    }
>> +}
>> diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
>> index e0fb28f..b84137e 100644
>> --- a/lib/librte_hash/rte_hash.h
>> +++ b/lib/librte_hash/rte_hash.h
>> @@ -318,6 +318,16 @@ rte_hash_lookup_bulk(const struct rte_hash *h, const void **keys,
>>    */
>>   unsigned int
>>   rte_hash_keys(const struct rte_hash *h, void *keys);
>> +
>> +/**
>> + * Clear all keys. This operation is not multi-thread safe and should only be
>> + * called from one thread.
>> + *
>> + * @param h
>> + *   Hash table to clear.
>> + */
>> +void
>> +rte_hash_clear(const struct rte_hash *h);
>>   #ifdef __cplusplus
>>   }
>>   #endif
>> -- 
>> 1.7.10.4
>>
>
>

  reply	other threads:[~2015-03-06 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06 11:10 Bruce Richardson
2015-03-06 12:02 ` Tomas Vestelind [this message]
2015-03-06 12:53   ` Bruce Richardson
  -- strict thread matches above, loose matches on Subject: below --
2014-08-12 21:47 Tomas Vestelind

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F99770.5040201@gmail.com \
    --to=tomas.vestelind@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git