From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 807CA9A8E for ; Mon, 9 Mar 2015 06:21:30 +0100 (CET) Received: by pdbfp1 with SMTP id fp1so55067565pdb.7 for ; Sun, 08 Mar 2015 22:21:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=7sM3JT2SEIX8usC7jbWnUFYKYMYWOUw8eeRp64Gcerk=; b=m6XGfqmRKBYmwFxNajSKFkuHpjxLg2XBIK/HPjHFdh1swEmLy5gYPyF6V1gPtRJ0Ra C6AYK5qnh5DunY1YLQImZl85L26vZLNX2IQssdqf05MyR0/acCBr3Sr/PVZXE959kmPB QFCFfNdsEa5rwojBKycarYsa32KP8Zq+ceCDX7cpwVG4TM3tNzqY338G6STqCQInSPar SinaaIfHs2ZBXkch5pDDxTvmgNefp+vHmMOdM2GuBVwz3RUvf7PU8COJUOUu3UNNdhl7 00TP8oWnylxWRBwtYDeP61JzQqtXjnBuSMQU5ZccJ/T6K/lq/aFSxAbuypRtGTZBR+sv EW9w== X-Gm-Message-State: ALoCoQkCX2r7xqsvPzC7EWUddCilN0cAzBGG8OBsPS2K37QharNf5tW9fErxfhIkQm4OtaNRVRAl X-Received: by 10.66.118.129 with SMTP id km1mr49748928pab.112.1425878489658; Sun, 08 Mar 2015 22:21:29 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id os6sm16970226pac.28.2015.03.08.22.21.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Mar 2015 22:21:29 -0700 (PDT) Message-ID: <54FD2DD7.5020604@igel.co.jp> Date: Mon, 09 Mar 2015 14:21:27 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Qiu, Michael" , "De Lara Guarch, Pablo" , "dev@dpdk.org" References: <1425540606-12554-1-git-send-email-mukawa@igel.co.jp> <533710CFB86FA344BFBF2D6802E60286CEEEC5@SHSMSX101.ccr.corp.intel.com> <54FD03FC.4010807@igel.co.jp> <533710CFB86FA344BFBF2D6802E60286CF051C@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CF051C@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix port validation code of "port stop all" command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 05:21:31 -0000 On 2015/03/09 12:49, Qiu, Michael wrote: > On 3/9/2015 10:22 AM, Tetsuya Mukawa wrote: >> On 2015/03/06 22:53, De Lara Guarch, Pablo wrote: >>> Hi Michael, >>> >>>> -----Original Message----- >>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiu, Michael >>>> Sent: Thursday, March 05, 2015 1:33 PM >>>> To: Tetsuya Mukawa; dev@dpdk.org >>>> Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix port validation code of= "port >>>> stop all" command >>>> >>>> Hi, Tetsuya and Pablo >>>> This is not a full fix, I have generate the full fix patch two days = ago, >> Hi Michel, >> >> I am sorry for late replying, and thanks for your work. >> >>> Sorry I did not see this earlier. Did you upstream this patch already= ? >>> I acked Tetsuya's patch, as it was simple and works, but I cannot fin= d >>> this one. >>> >>> Thanks, >>> Pablo >>> >>>> See below: >>>> >>>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >>>> index 49be819..ec53923 100644 >>>> --- a/app/test-pmd/config.c >>>> +++ b/app/test-pmd/config.c >>>> @@ -384,6 +384,9 @@ port_infos_display(portid_t port_id) >>>> int >>>> port_id_is_invalid(portid_t port_id, enum print_warning warning) >>>> { >>>> + if (port_id =3D=3D (portid_t)RTE_PORT_ALL) >>>> + return 0; >>>> + >> I am not clearly sure that we need to add above 'if statement'. > Because some times RTE_PORT_ALL will pass to port start/stop/close, but= > the check will be invalid. > > Actually, we should see it as valid, then all port valid check will wor= k > for start/stop/close action > >>>> if (ports[port_id].enabled) >>>> return 0; >>>> >>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c >>>> index e556b4c..1c4c651 100644 >>>> --- a/app/test-pmd/testpmd.c >>>> +++ b/app/test-pmd/testpmd.c >>>> @@ -1326,6 +1326,9 @@ start_port(portid_t pid) >>>> return -1; >>>> } >>>> >>>> + if (port_id_is_invalid(pid, ENABLED_WARN)) >>>> + return 0; >>>> + >> Same as above. >> >>>> if (init_fwd_streams() < 0) { >>>> printf("Fail from init_fwd_streams()\n"); >>>> return -1; >>>> @@ -1482,10 +1485,14 @@ stop_port(portid_t pid) >>>> dcb_test =3D 0; >>>> dcb_config =3D 0; >>>> } >>>> + >>>> + if (port_id_is_invalid(pid, ENABLED_WARN)) >>>> + return; >>>> + >> Same as above. >> >>>> printf("Stopping ports...\n"); >>>> >>>> FOREACH_PORT(pi, ports) { >>>> - if (!port_id_is_invalid(pid, DISABLED_WARN) && pid != =3D pi) >>>> + if (pid !=3D pi && pid !=3D (portid_t)RTE_PORT_ALL) >>>> continue; >>>> >>>> port =3D &ports[pi]; >>>> @@ -1517,10 +1524,13 @@ close_port(portid_t pid) >>>> return; >>>> } >>>> >>>> + if (port_id_is_invalid(pid, ENABLED_WARN)) >>>> + return; >>>> + >> Same as above. >> >>>> printf("Closing ports...\n"); >>>> >>>> FOREACH_PORT(pi, ports) { >>>> - if (!port_id_is_invalid(pid, DISABLED_WARN) && pid != =3D pi) >>>> + if (pid !=3D pi && pid !=3D (portid_t)RTE_PORT_ALL) >>>> continue; >>>> >>>> port =3D &ports[pi]; >>>> -- >>>> 1.9.3 >> FOREACH_PORT() returns valid ports, so is it not enough to check like = above? >> I am not clearly understand which case we need to add above extra if >> statements. >> Could you please describe? > Yes, just consider this situation, the valid port number are [0, 1], > but you try to to stop prot number 2, what will happen? > > Noting will be show, at least we need an error log. > > So it must be check. Hi Michael, Thanks, I've understood it. Have you already submitted it as patch? I could not find it in patchwork. I will send an ack to your patch. Thanks, Tetsuya > Thanks, > Michael >> But I agree we cannot use my previous patch. >> We need to fix not only stop_port() but also close_port() like start_p= ort(). >> >> Thanks, >> Tetsuya >> >>>> Thanks, >>>> Michael >>>> >>>> On 3/5/2015 3:31 PM, Tetsuya Mukawa wrote: >>>>> When "port stop all" is executed, the command doesn't work as it sh= ould >>>>> because of wrong port validation. The patch fixes this issue. >>>>> >>>>> Reported-by: Pablo de Lara >>>>> Signed-off-by: Tetsuya Mukawa >>>>> --- >>>>> app/test-pmd/testpmd.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c >>>>> index 61291be..bb65342 100644 >>>>> --- a/app/test-pmd/testpmd.c >>>>> +++ b/app/test-pmd/testpmd.c >>>>> @@ -1484,7 +1484,7 @@ stop_port(portid_t pid) >>>>> printf("Stopping ports...\n"); >>>>> >>>>> FOREACH_PORT(pi, ports) { >>>>> - if (!port_id_is_invalid(pid, DISABLED_WARN) && pid !=3D pi) >>>>> + if (pid !=3D pi && pid !=3D (portid_t)RTE_PORT_ALL) >>>>> continue; >>>>> >>>>> port =3D &ports[pi]; >>