From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vladz@cloudius-systems.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 4BDD05A9C
 for <dev@dpdk.org>; Mon,  9 Mar 2015 08:08:47 +0100 (CET)
Received: by wiwl15 with SMTP id l15so16478043wiw.1
 for <dev@dpdk.org>; Mon, 09 Mar 2015 00:08:47 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=XriWw5wSFt2YifesXEdhq8rxH6OyD/mw9+nfRJXZwsM=;
 b=MTbBZn7s4sRFCAa3ksgUErkrXNII24gfAXgCo/SWrliefpEfgn2yz21k69szaFWTrw
 az7TBwSNWHSvi7gW0BcXhSSgGEe85t7fd65vvhqk+uRLOTfav1+afB77v49QQVpv9IKC
 MoOFPPjxmfyYhx7B4pKNVT5rRzmqBZxpKUFt/y9a4dZz2v+OLDqQzYD3IrSgS17wkBuv
 m7ZFO72d7axSG0Suyliq7QVnlrm0kgwcgHrE5fGb+mnoGBrmMzh7zD1nDQWSxj6opKaY
 fSVXRH00OfPSEeg3wXHgrAfcthxxooVK2U+3GTK5zsouoWWSOkGFfBUYVul44YXXMXe8
 nRNw==
X-Gm-Message-State: ALoCoQk4K+yyrHIauD8m7uIc6XjwqCor6DsElBHWGXLR5ssgv5OpTZkNJWXpMXRmRHbSc4wSS48k
X-Received: by 10.180.206.144 with SMTP id lo16mr57944486wic.28.1425884927087; 
 Mon, 09 Mar 2015 00:08:47 -0700 (PDT)
Received: from [192.168.43.130] ([46.19.85.214])
 by mx.google.com with ESMTPSA id fm10sm14195952wib.7.2015.03.09.00.08.45
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 09 Mar 2015 00:08:46 -0700 (PDT)
Message-ID: <54FD46FC.5010608@cloudius-systems.com>
Date: Mon, 09 Mar 2015 09:08:44 +0200
From: Vlad Zolotarov <vladz@cloudius-systems.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com>
 <1425823498-30385-3-git-send-email-vladz@cloudius-systems.com>
 <3162156.p89LbuxRO9@xps13>
In-Reply-To: <3162156.p89LbuxRO9@xps13>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx
 CRC stripping for x540 devices
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Mar 2015 07:08:47 -0000



On 03/08/15 23:12, Thomas Monjalon wrote:
> Hi Vlad,
>
> 2015-03-08 16:04, Vlad Zolotarov:
>> According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should
>> be configured to the same value as HLREG0.RXCRCSTRP.
>>
>> Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec
>> but seems harmless.
>>
>> Signed-off-by: Vlad Zolotarov <vladz@cloudius-systems.com>
> You are mixing a fix (this patch) and enhancements (LRO) in the same series.
> Could you separate them please, as LRO is not going into 2.0 but this fix
> is a good candidate.

Pls, note that all patches in this series except for PATCH3 and PATCH5 
are fixing real bugs. I can send them as a separate series if u'd like.
Pls., confirm.

>
> Thanks