From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 2CA2B5A69 for ; Mon, 9 Mar 2015 08:31:28 +0100 (CET) Received: by wggz12 with SMTP id z12so6636608wgg.0 for ; Mon, 09 Mar 2015 00:31:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=guD2kOrlA2Av0TDROVDWzrdgtbpZQufjrNKRgVC6/So=; b=l0/q17/zyYMNtOjCNFdiMWHVqoe781JJPXKdoWHLB3WzxZ/eUvhkb07BaFVXCPeUew /80ha5uKhymZ2hObx4XVOjrcMbJVQi5iaDBURZegh6aW6fC/AELh71j7R/y8zGSPY1wg bo0ByJ1PbrvooYpuuR3lvSf2t12cb0Rh/Njx0ECvkxJEGGTE6Yd4I6FcN6hO5F6vKJIm p522qiznRHm0egoRMbibcwxhoqKjk2W2xQd8F3z35YBriIuczaGPcYOwJlNImllnCnT+ S+777CZT8icSXsMc4Vg+KTbzW6PNSIY4KoF0Y3hpHAY6fPxlAokAbtHgfLDuzLom4Cz5 g1Dg== X-Gm-Message-State: ALoCoQmMuW2pG6IJHfDNxTNVwTPcUiCYy3vMr6Sh9MMK9WYeO8qniwr8kEvX3Vone111pVjVIeey X-Received: by 10.180.77.196 with SMTP id u4mr102694867wiw.6.1425886288025; Mon, 09 Mar 2015 00:31:28 -0700 (PDT) Received: from [192.168.43.130] ([46.19.85.214]) by mx.google.com with ESMTPSA id q6sm14260358wix.13.2015.03.09.00.31.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 00:31:27 -0700 (PDT) Message-ID: <54FD4C4D.3000607@cloudius-systems.com> Date: Mon, 09 Mar 2015 09:31:25 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Thomas Monjalon References: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com> <1425823498-30385-3-git-send-email-vladz@cloudius-systems.com> <3162156.p89LbuxRO9@xps13> In-Reply-To: <3162156.p89LbuxRO9@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 07:31:28 -0000 On 03/08/15 23:12, Thomas Monjalon wrote: > Hi Vlad, > > 2015-03-08 16:04, Vlad Zolotarov: >> According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should >> be configured to the same value as HLREG0.RXCRCSTRP. >> >> Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec >> but seems harmless. >> >> Signed-off-by: Vlad Zolotarov > You are mixing a fix (this patch) and enhancements (LRO) in the same series. I'd also like to clarify that I've "mixed" them because the bugs were found in the area of the enhancement therefore I united them in the same series. Frankly, I wasn't thinking about the DPDK versions it's going into when I sent the series... ;) > Could you separate them please, as LRO is not going into 2.0 but this fix > is a good candidate. > > Thanks