From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 877625FEB for ; Mon, 9 Mar 2015 11:46:07 +0100 (CET) Received: by wghl18 with SMTP id l18so19776780wgh.11 for ; Mon, 09 Mar 2015 03:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=E35RJxKXIO2EPvX0g161lIoiDR9VFeD9ZFy8sFDEBDc=; b=aAT2MnSkZbkelStRyWnYMRb27BG7A8Dsjs+XsT3pqz/9UlkC2Dl4VW12QqrIfvQebv 7QZKlqyHX8VLDPPMZ0TnewsCur8ID71LP3qQ3JlJJaXDvFTMkjMOKO5WfJw9v9FRtSPI 0LEQYM2cVA9qb7z7UUiQvrj7Gvo4eqHGIoW4bNIYXjORqslOz+pxJBDEPeCpmwF54kYB DTGlVOlSU2TO3WMUWf7F7kCAq/q/cIHd0N3AZ3TSBxIelnIBQgM3H/bvqjuq2i9Hg+Nj Pa+Te2fw5fqmq0k1ss4oujc8ZPhXkX3TSiVyhsP7QAIf4shDhx+ZTQkvK3VMUF2Jocsp 4PMQ== X-Gm-Message-State: ALoCoQnhLLDPrldS1llsI93x3glHTmk7rUMYYxnHh+hAlik7dbcMyZMV0QJ4lqj0bUrBytFmBx3U X-Received: by 10.180.184.169 with SMTP id ev9mr35818699wic.76.1425897967335; Mon, 09 Mar 2015 03:46:07 -0700 (PDT) Received: from [10.0.0.2] (bzq-109-65-117-109.red.bezeqint.net. [109.65.117.109]) by mx.google.com with ESMTPSA id dj4sm27694712wjc.13.2015.03.09.03.46.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 03:46:06 -0700 (PDT) Message-ID: <54FD79ED.80609@cloudius-systems.com> Date: Mon, 09 Mar 2015 12:46:05 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: dev@dpdk.org References: <1425896433-12452-1-git-send-email-vladz@cloudius-systems.com> In-Reply-To: <1425896433-12452-1-git-send-email-vladz@cloudius-systems.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 0/3]This series adds the missing flow for enabling the LRO in the ethdev and X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 10:46:07 -0000 On 03/09/15 12:20, Vlad Zolotarov wrote: > The series starts with some cleanup work in the code the final patch (the actual adding of > the LRO support) is going to touch/use/change. There are still quite a few issues in the ixgbe > PMD code left but they have to be a matter of a different series and I've left a few "TODO" > remarks in the code. > > The LRO ("RSC" in Intel's context) PMD completion handling code follows the same design as the > corresponding Linux and FreeBSD implementation: pass the aggregation's cluster HEAD buffer to > the NEXTP entry of the software ring till EOP is met. > > HW configuration follows the corresponding specs: this feature is supported only by x540 and > 82599 PF devices. > > The feature has been tested with seastar TCP stack with the following configuration on Tx side: > - MTU: 400B > - 100 concurrent TCP connections. > > The results were: > - Without LRO: total throughput: 0.12Gbps, coefficient of variance: 1.41% > - With LRO: total throughput: 8.21Gbps, coefficient of variance: 0.59% > > This is an almost factor 80 improvement. Pls., note that this series is a followup series to the "bug fixes in the ixgbe PF PMD Rx flow" series I've sent before. thanks, vlad > > New in v5: > - Split the series into "bug fixes" and "all the rest" so that the former could be > integrated into a 2.0 release. > - Put the RTE_ETHDEV_HAS_LRO_SUPPORT definition at the beginning of rte_ethdev.h. > - Removed the "TODO: Remove me" comment near RTE_ETHDEV_HAS_LRO_SUPPORT. > > New in v4: > - Remove CONFIG_RTE_ETHDEV_LRO_SUPPORT from config/common_linuxapp. > - Define RTE_ETHDEV_HAS_LRO_SUPPORT in rte_ethdev.h. > - As a result of "ixgbe: check rxd number to avoid mbuf leak" (352078e8e) Vector Rx > had to get the same treatment as Rx Bulk Alloc (see PATCH4 for more details). > > New in v3: > - ixgbe_rx_alloc_bufs(): Always reset refcnt of the buffers to 1. Otherwise rte_pktmbuf_free() > won't free them. > > New in v2: > - Removed rte_eth_dev_data.lro_bulk_alloc and added ixgbe_hw.rx_bulk_alloc_allowed > instead. > - Unified the rx_pkt_bulk callback setting (a separate new patch). > - Fixed a few styling and spelling issues. > > > Vlad Zolotarov (3): > ixgbe: Cleanups > ixgbe: Code refactoring > ixgbe: Add LRO support > > lib/librte_ether/rte_ethdev.h | 9 +- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 6 + > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 5 + > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 703 ++++++++++++++++++++++++++++++++---- > lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 6 + > 5 files changed, 662 insertions(+), 67 deletions(-) >