From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id C07079A91 for ; Mon, 9 Mar 2015 16:57:59 +0100 (CET) Received: by wesk11 with SMTP id k11so5406753wes.13 for ; Mon, 09 Mar 2015 08:57:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=JVjV2tgmRzGnTuHsklNNPBk76UsJtTj1gxzRtK0KEO0=; b=fbKswenLZEymsOKURg1ZJUIhOaSLKbDrZZjD14D9YhSEqCU9bRxv0wrN8AiDGIVZ34 w6a9I8bA6kB9G4odiAZTA3jiYgecrfe+KAY+wsbzgh6ycH6rhYpWlhNuX7WcQnF1Bolj aGQsDz3IeJdhHJPtSAw2yoV/zpuMBz7BM1HyuNG24baymldIyfPCOlAWKZykidIETu6e WFI0NeVXiB9OJYd6eMuDafgpqGJYJqyLDTJ0mmXymSOJAt+wXZkfnxwU1VwPbp8Cnphx LjoUOFZ2CP5BDVwcwQ65zAdpry0IEQY4BCsU7V1o9OJRnM7y3noOSDuEP402bRbhRFfc jR9w== X-Gm-Message-State: ALoCoQleDH3EFGqa11GVk4NomM42Qyw/qahC6u1q70di9B4S9C81IkAmynavrS9kPcDhVkk1YE9O X-Received: by 10.194.122.196 with SMTP id lu4mr59705658wjb.154.1425916679607; Mon, 09 Mar 2015 08:57:59 -0700 (PDT) Received: from [10.0.0.2] ([109.65.117.109]) by mx.google.com with ESMTPSA id dx11sm28811038wjb.23.2015.03.09.08.57.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 08:57:59 -0700 (PDT) Message-ID: <54FDC306.4030503@cloudius-systems.com> Date: Mon, 09 Mar 2015 17:57:58 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Ananyev, Konstantin" , "Wodkowski, PawelX" , "dev@dpdk.org" References: <1425896433-12452-1-git-send-email-vladz@cloudius-systems.com> <1425896433-12452-2-git-send-email-vladz@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F4B37@irsmsx105.ger.corp.intel.com> <54FD7F5A.4090809@intel.com> <2601191342CEEE43887BDE71AB977258213F4B99@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258213F4B99@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 15:58:00 -0000 On 03/09/15 13:29, Ananyev, Konstantin wrote: > >> -----Original Message----- >> From: Wodkowski, PawelX >> Sent: Monday, March 09, 2015 11:09 AM >> To: Ananyev, Konstantin; Vlad Zolotarov; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >> >> On 2015-03-09 11:49, Ananyev, Konstantin wrote: >>> >>>> -----Original Message----- >>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov >>>> Sent: Monday, March 09, 2015 10:21 AM >>>> To: dev@dpdk.org >>>> Subject: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >>>> >>>> - Removed the not needed casting. >>>> - ixgbe_dev_rx_init(): shorten the lines by defining a local alias variable to access >>>> &dev->data->dev_conf.rxmode. >>>> >>>> Signed-off-by: Vlad Zolotarov >>>> --- >>>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 27 ++++++++++++--------------- >>>> 1 file changed, 12 insertions(+), 15 deletions(-) >>>> >>>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >>>> index 72c65df..609b5fd 100644 >>>> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >>>> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >>>> @@ -1032,8 +1032,7 @@ ixgbe_rx_alloc_bufs(struct igb_rx_queue *rxq) >>>> int diag, i; >>>> >>>> /* allocate buffers in bulk directly into the S/W ring */ >>>> - alloc_idx = (uint16_t)(rxq->rx_free_trigger - >>>> - (rxq->rx_free_thresh - 1)); >>>> + alloc_idx = rxq->rx_free_trigger - (rxq->rx_free_thresh - 1); >>> I think all these extra casts came in to keep icc 12.* compiling without warnings. >>> I am agree that they are unnecessary. >>> Though if we still have to support icc 12.* we either need to keep them, or find >>> some other way to keep it happy. >>> Konstantin >>> >> What warnings icc 12.* is throwing? > Try and see :) > >> Only warning I can think of here is >> signed -> unsigned implicit cast. > If I remember things correctly, it considered result at right side of '=' operator as unsigned int, > and then complained that we assign it to smaller size (unsigned short) operand. If that's the case - that's a clear compiler bug. > >> Changing '1' to '1U' helps? > Don't think so, but you are welcome to try. > > Konstantin > >> >> -- >> Pawel