From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 5E7C95938 for ; Mon, 9 Mar 2015 17:10:26 +0100 (CET) Received: by wesp10 with SMTP id p10so7327977wes.11 for ; Mon, 09 Mar 2015 09:10:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=mOwy4TyA/wsiDI7IQn3ZngNGhXYFUXCnn/ECicZKLcA=; b=kDvKLq7z07kHP3fIrxPgahIrocwWyQTRiLtHDUmiiWdy3DqpwzI5TVGMciJwtVRy/E yytWawc1xoHNi3/rQ+qgzZhVwfOiKHtPuf0po1Wg+x3WuYWvqOksHic614I3tB25LpL/ HBjHHi6Vvas1cY3E4TurtfVdC1+n8ye7VWfigxtQS8Uuco0foM8FnFPSaclTk7I8eyfJ 2Nk2fdPUFuZ62G1ROhlX6qn05AqYup26Si939qt1O3WJ7Cl7ulTQEWzjjeuNttMjYE01 gfXuPbY92AUnMM07HAXag25DIrOL2MZWG1RE/OgZfJB5tj95qNkr7luZ38XOllCyZ6tT fCDA== X-Gm-Message-State: ALoCoQmhFFPcX7X1Mk7sAgcaXQkiRU/3KUxa7KsAXE0bsClmRW6xdrKrUowWq4ak5MQvwPN8qHaQ X-Received: by 10.194.156.202 with SMTP id wg10mr60746953wjb.70.1425917426131; Mon, 09 Mar 2015 09:10:26 -0700 (PDT) Received: from [10.0.0.2] ([109.65.117.109]) by mx.google.com with ESMTPSA id kj8sm28853443wjc.29.2015.03.09.09.10.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 09:10:25 -0700 (PDT) Message-ID: <54FDC5F0.8050901@cloudius-systems.com> Date: Mon, 09 Mar 2015 18:10:24 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Thomas Monjalon References: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com> <3162156.p89LbuxRO9@xps13> <54FD46FC.5010608@cloudius-systems.com> <2357467.DFWlgGcAaX@xps13> In-Reply-To: <2357467.DFWlgGcAaX@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 16:10:26 -0000 On 03/09/15 09:58, Thomas Monjalon wrote: > 2015-03-09 09:08, Vlad Zolotarov: >> On 03/08/15 23:12, Thomas Monjalon wrote: >>> Hi Vlad, >>> >>> 2015-03-08 16:04, Vlad Zolotarov: >>>> According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should >>>> be configured to the same value as HLREG0.RXCRCSTRP. >>>> >>>> Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec >>>> but seems harmless. >>>> >>>> Signed-off-by: Vlad Zolotarov >>> You are mixing a fix (this patch) and enhancements (LRO) in the same series. >>> Could you separate them please, as LRO is not going into 2.0 but this fix >>> is a good candidate. >> Pls, note that all patches in this series except for PATCH3 and PATCH5 >> are fixing real bugs. I can send them as a separate series if u'd like. >> Pls., confirm. > Yes you're right, patch 1 is also a fix and patch 4 seems to solve other > issues. However, patch 4 makes also some refactoring and seems a bit risky. > We need an ixgbe maintainer to decide wether we can merge it before the > release. Or is it possible to have fixes of the patch 4 without the > refactoring? > > Thanks Vlad. > Sorry to request such split but this PMD is sensible and I don't want to > have a risk of making it worst in release 2.0. Well, IMHO PATCH4 here has the most important and critical fix among other patches - the whole port is going to be configured according to the last queue configuration. Consider the case when queues are configured differently and the last one meets vector Rx requirements: bulk allocation requirements, descriptors number is a power of 2 (there are per-port requirements too). But the first queue may be configured to have a different number of descriptors, which is NOT a power of two. Currently the port's rx_pkt_burst callback will be configured to use a vercot Rx callback and we would hit the same issue reported by Stephen and "fixed" in 352078e8e.