From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id 47530592B for ; Mon, 9 Mar 2015 17:30:14 +0100 (CET) Received: by wesk11 with SMTP id k11so5734826wes.13 for ; Mon, 09 Mar 2015 09:30:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=NlewBKG15/NHo+IjWWFbhxgRHW129/ZE39g81lzXVD0=; b=HZaDFpyeReznAVe90mbY7BpxYeZfa4R00l2ImgAnwyOQxqWp4JED6OdcpfGFfzXeE9 3dzJNfO/9yFwmf3CSZWxSEW9SeAuYje9tLFP7xxkJySRP0RaC5wshgT+KsPx9JU3A5f9 um+1eZHQUJFkNaRzRC1UQ7yY1hCkVrR9ENv6kqf/X5sG50QVQpl9TSZh/Sq2eiTTXZ5C eqV5nC5hvXFPHvtl5ginKkv73/FX45s/7dyWRWPA3lVj+xpJEcxjl6yU0k7nuAXS9H0f t4ZGyXXl4uBa1xkfhNSO30sxq/RPL7sSqm4CsgyhWK3kW1RrCeX8jhdF+BkQfIaqKwIR oQgA== X-Gm-Message-State: ALoCoQlzCSkZhHhsmIRR0Bkhu4e8fUYSfCUXO0uBssxfiQEi8lDeDin7CAZkdKphZop5xIdKU48x X-Received: by 10.180.102.234 with SMTP id fr10mr2311502wib.48.1425918614094; Mon, 09 Mar 2015 09:30:14 -0700 (PDT) Received: from [10.0.0.2] ([109.65.117.109]) by mx.google.com with ESMTPSA id nd15sm5806718wic.8.2015.03.09.09.30.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 09:30:13 -0700 (PDT) Message-ID: <54FDCA94.6040507@cloudius-systems.com> Date: Mon, 09 Mar 2015 18:30:12 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Mcnamara, John" , "dev@dpdk.org" References: <1425895968-8597-1-git-send-email-vladz@cloudius-systems.com> <1425895968-8597-4-git-send-email-vladz@cloudius-systems.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 16:30:14 -0000 On 03/09/15 15:39, Mcnamara, John wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Monday, March 9, 2015 10:13 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v1 3/3] ixgbe: Unify the rx_pkt_bulk callback >> initialization >> >> @@ -3641,23 +3676,17 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev) >> buf_size = (uint16_t) ((srrctl & IXGBE_SRRCTL_BSIZEPKT_MASK) >> << >> IXGBE_SRRCTL_BSIZEPKT_SHIFT); >> >> - if (dev->data->dev_conf.rxmode.enable_scatter || >> - /* It adds dual VLAN length for supporting dual VLAN */ >> - (dev->data->dev_conf.rxmode.max_rx_pkt_len + >> - 2 * IXGBE_VLAN_TAG_SIZE) > buf_size){ >> - if (!dev->data->scattered_rx) >> - PMD_INIT_LOG(DEBUG, "forcing scatter mode"); >> + /* It adds dual VLAN length for supporting dual VLAN */ >> + if (dev->data->dev_conf.rxmode.max_rx_pkt_len + >> + 2 * IXGBE_VLAN_TAG_SIZE > buf_size) >> dev->data->scattered_rx = 1; >> -#ifdef RTE_IXGBE_INC_VECTOR >> - if (rte_is_power_of_2(rxq->nb_rx_desc)) >> - dev->rx_pkt_burst = >> - ixgbe_recv_scattered_pkts_vec; >> - else >> -#endif >> - dev->rx_pkt_burst = ixgbe_recv_scattered_pkts; >> - } >> } >> >> + if (rx_conf->enable_scatter) >> + dev->data->scattered_rx = 1; > Hi, > > There is a compilation issue here when this patch is applied to the current master (with previous 2 patches applied as well): > > make T=x86_64-native-linuxapp-gcc install CC=gcc > ... > == Build lib/librte_pmd_ixgbe > CC ixgbe_rxtx.o > /home/user/dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function 'ixgbe_dev_rx_init': > /home/user/dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx.c:3689:6: error: 'rx_conf' undeclared (first use in this function) > /home/user/dpdk/lib/librte_pmd_ixgbe/ixgbe_rxtx.c:3689:6: note: each undeclared identifier is reported only once for each function it appears in > make[5]: *** [ixgbe_rxtx.o] Error 1 > > This is using the default DPDK linuxapp config. v2 is out. Again, my apologize. ;) > > John >