From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id F356D5FEB for ; Mon, 9 Mar 2015 20:30:36 +0100 (CET) Received: by wggx12 with SMTP id x12so17073825wgg.10 for ; Mon, 09 Mar 2015 12:30:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=/57u8WDizBb9SyedFesMQj8iohCohwSdAmNqTmv5vKA=; b=jalb4OIVJXNNHCpTkiqRm422kYbFu0zIlNp6uU6J0zXNxlvJGwltgQ9GSYjDYsb8sm 26FfWM3HkhJgEBkQWdmvqT/QglO0ZCdZWCwgBP3Q5rMDAhlc+1RrjMqrzzpWgC+etMSo 3aggpy017hhGqgVQbG3FrHKH65QcCvZq3sA3n9Wl2XDXBq4j2Hk3TZ0Qn+73qWY+j+pY ScYEwutPGEyZyXbouPx+MUJubXd/7qUZY/mBS/p5PqvsvjnKIXwDPb/xNkBIIUJIwzWa aGnk6mHti0Z5AlzSEWhuWMRb+cUB+XQZcMs92IINSmV4nBrUsR/bgHEeADuG9uMRu9Z9 DLBg== X-Gm-Message-State: ALoCoQn14d+ysKPR55fMB+XK/QjsO/B56PJOnCHtOP4a0QhSTPHPPZvHuuuQnF/fevKBfjHrwHeN X-Received: by 10.180.79.232 with SMTP id m8mr108575989wix.81.1425929436866; Mon, 09 Mar 2015 12:30:36 -0700 (PDT) Received: from [10.0.0.2] (bzq-109-65-117-109.red.bezeqint.net. [109.65.117.109]) by mx.google.com with ESMTPSA id g5sm29545375wjr.19.2015.03.09.12.30.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 12:30:36 -0700 (PDT) Message-ID: <54FDF4DA.3020609@cloudius-systems.com> Date: Mon, 09 Mar 2015 21:30:34 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Thomas Monjalon References: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com> <3162156.p89LbuxRO9@xps13> <54FD46FC.5010608@cloudius-systems.com> <2357467.DFWlgGcAaX@xps13> In-Reply-To: <2357467.DFWlgGcAaX@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 19:30:37 -0000 On 03/09/15 09:58, Thomas Monjalon wrote: > 2015-03-09 09:08, Vlad Zolotarov: >> On 03/08/15 23:12, Thomas Monjalon wrote: >>> Hi Vlad, >>> >>> 2015-03-08 16:04, Vlad Zolotarov: >>>> According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should >>>> be configured to the same value as HLREG0.RXCRCSTRP. >>>> >>>> Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec >>>> but seems harmless. >>>> >>>> Signed-off-by: Vlad Zolotarov >>> You are mixing a fix (this patch) and enhancements (LRO) in the same series. >>> Could you separate them please, as LRO is not going into 2.0 but this fix >>> is a good candidate. >> Pls, note that all patches in this series except for PATCH3 and PATCH5 >> are fixing real bugs. I can send them as a separate series if u'd like. >> Pls., confirm. > Yes you're right, patch 1 is also a fix and patch 4 seems to solve other > issues. However, patch 4 makes also some refactoring and seems a bit risky. > We need an ixgbe maintainer to decide wether we can merge it before the > release. Or is it possible to have fixes of the patch 4 without the > refactoring? > > Thanks Vlad. > Sorry to request such split but this PMD is sensible and I don't want to > have a risk of making it worst in release 2.0. I've separated the series into two: "bug fixes" and "cleanups + refactoring + LRO feature". Both series are already on the list. ;)