From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 551B79A8E for ; Mon, 9 Mar 2015 20:32:12 +0100 (CET) Received: by wibbs8 with SMTP id bs8so24664302wib.4 for ; Mon, 09 Mar 2015 12:32:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=9YQoH1HD3OWBBBs7GRm2VxdMtVnAAg+B5zBCpJkPHxo=; b=OhWkAGdVOorOl1fdifPOdP129ZllWkanRPf81TEKVV7sW/YXwMczfFp3EjIET1mMQK hTLCw4ZTF9SnXo1Sy+fd+e+//LYqWWkrq4KOCqt4y2LGqh0D8tyfRPbH5KfGpvy1IL2I PGHk6xq1McVIFTPp5vAc10XuF2CNdbflDxwTImq0gjeiAiw6UP9lk9AnjZPatpAgeU+U PhrEg8iy6m2mTKtTaxYAyBqjOYaTDHall3ta1mLdSy1lLjWxHCAa9Jj7lhO1ZtwQompp X784zodDcMVmHw5CxPtmQq0Iu8ESh/HeXx8WKqxSvRKGBTbx2luHzawWDriL+a76z4o8 J3ng== X-Gm-Message-State: ALoCoQnI06NDvZqmwAqpEiR3EpsRdANv8GdTYr/lurAxdP+eIgHix2MTUNq9aYg33ctO9Em9+20h X-Received: by 10.180.94.199 with SMTP id de7mr44526498wib.53.1425929532209; Mon, 09 Mar 2015 12:32:12 -0700 (PDT) Received: from [10.0.0.2] ([109.65.117.109]) by mx.google.com with ESMTPSA id nb4sm11056986wjc.20.2015.03.09.12.32.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 12:32:11 -0700 (PDT) Message-ID: <54FDF53A.7090901@cloudius-systems.com> Date: Mon, 09 Mar 2015 21:32:10 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Ananyev, Konstantin" References: <1425896433-12452-1-git-send-email-vladz@cloudius-systems.com> <1425896433-12452-2-git-send-email-vladz@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F4B37@irsmsx105.ger.corp.intel.com> <54FD7F5A.4090809@intel.com> <2601191342CEEE43887BDE71AB977258213F4B99@irsmsx105.ger.corp.intel.com> <54FDC306.4030503@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F4E68@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258213F4F13@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258213F4F4B@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258213F4F4B@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 19:32:12 -0000 On 03/09/15 21:13, Ananyev, Konstantin wrote: > >> From: Vladislav Zolotarov [mailto:vladz@cloudius-systems.com] >> Sent: Monday, March 09, 2015 6:22 PM >> To: Mcnamara, John >> Cc: dev@dpdk.org; Ananyev, Konstantin >> Subject: RE: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >> >> >> On Mar 9, 2015 8:01 PM, "Mcnamara, John" wrote: >>>> -----Original Message----- >>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vladislav Zolotarov >>>> Sent: Monday, March 9, 2015 5:14 PM >>>> To: Ananyev, Konstantin >>>> Cc: dev@dpdk.org >>>> Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups >>>> >>>> On Mar 9, 2015 6:39 PM, "Ananyev, Konstantin" >>>> >>>> wrote: >>>>>>> If I remember things correctly, it considered result at right side >>>>>>> of >>>> '=' operator as unsigned int, >>>>>>> and then complained that we assign it to smaller size (unsigned >>>> short) operand. >>>>>> If that's the case - that's a clear compiler bug. >>>>> Might be, though if we still have to support it, there is no much >>>>> choice >>>> I am afraid. >>>> >>>> Well to begin with could anybody who has this icc thing (preferably the >>>> latest version) post the compilation errors u are talking about >>> Hi, >>> >>> For what it is worth there aren't any warnings with ICC 13 and the 1/3 patch (+ the previous patchset): >>> >>> $ make T=x86_64-native-linuxapp-icc install CC=icc >>> Build complete >>> >>> $ git log --pretty=format:"%h - %an: %s" -4 >>> b5d06e4 - Vladislav Zolotarov: ixgbe: Cleanups >>> 3cd0367 - Vladislav Zolotarov: ixgbe: Unify the rx_pkt_bulk callback ... >>> 10ed30e - Vladislav Zolotarov: ixgbe: Bug fix: Properly configure Rx ... >>> 2a5bc6a - Vladislav Zolotarov: ixgbe: Use the rte_le_to_cpu_xx()/rte_... >>> >>> $ icc --version >>> icc (ICC) 13.1.1 20130313 >> Thanks a lot, John. > As I said my worry was about 12.*. > icc v13* and above, are not that picky. > After applying the patch, indeed all these lines make icc 12.1 to generate warnings. > See below for details. > Though with icc 12.1 current dpdk.org main branch will generate ~2K unhandled warnings all over the places anyway... > Which makes me think that probably DPDK support for icc 12.* was scrapped already, I just didn't notice that. So, I suppose this concludes this specific discussion, right? ;) > Konstantin > > $ icc -v > icc version 12.1.0 (gcc version 4.5.0 compatibility) > > $ icc -Wp,-MD,./.ixgbe_rxtx.o.d.tmp -m64 -pthread -march=native -DRTE_MACHINE_CPU > FLAG_SSE -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 -DRTE_MACHINE_CPU > FLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SSE4_1 -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHI > NE_CPUFLAG_AVX -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_ > CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG > _AVX -I/local/kananye1/dpdk.org/x86_64-native-linuxapp-icc/include -include /lo > cal/kananye1/dpdk.org/x86_64-native-linuxapp-icc/include/rte_config.h -O3 -Wall > -w2 -diag-disable 271 -diag-warning 1478 -diag-disable 13368 -diag-disable 15527 -o ixgbe_rxtx.o -c /local/kananye1/dpdk.org/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > > .... > > /local/kananye1/dpdk.org/lib/librte_pmd_ixgbe/ixgbe_rxtx.c(1035): remark #2259: > non-pointer conversion from "int" to "uint16_t={unsigned short}" may lose signif > icant bits > alloc_idx = rxq->rx_free_trigger - (rxq->rx_free_thresh - 1); > ^ > > /local/kananye1/dpdk.org/lib/librte_pmd_ixgbe/ixgbe_rxtx.c(1064): remark #2259: non-pointer conversion from "int" to "uint16_t={unsigned short}" may lose significant bits > rxq->rx_free_trigger = rxq->rx_free_trigger + rxq->rx_free_thresh; > ^ > > /local/kananye1/dpdk.org/lib/librte_pmd_ixgbe/ixgbe_rxtx.c(1067): remark #2259: non-pointer conversion from "int" to "uint16_t={unsigned short}" may lose significant bits > rxq->rx_free_trigger = rxq->rx_free_thresh - 1; > > .... >