From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B706E45681; Mon, 22 Jul 2024 15:06:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A69D2402AC; Mon, 22 Jul 2024 15:06:31 +0200 (CEST) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mails.dpdk.org (Postfix) with ESMTP id EDF78400D7 for ; Mon, 22 Jul 2024 15:06:29 +0200 (CEST) Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52f025ab3a7so1686023e87.2 for ; Mon, 22 Jul 2024 06:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1721653589; x=1722258389; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ensa/m/Mn9bhaexLvPaDgTLeVijtjb4maDtg90FQukY=; b=e+djRUrQMw7TR8fb9XJsxPBSeLTsiWqUTWilVQ3MGkmySWbR33pY7ZNdl+zgJJWHeu WnIDf0ODKjXUXWfdZghADpyCb+g5HVlESXbyMt89fE15BH4D1sVtI5FC96CToyanAd6f XVeaN+5/ZzcKhtSs4EXWiHDEQZBTwn/joA/yrAqKsOI9RjWuTgJ3wspNlXTGxtR/cY5p R9f4zScz+hzyjmd/nyFf16ix52Hvsqsf3PCDLg/WfoyKXxLtHvNvSOpa2AHKrOGu6SCC PxiUukpYiNE3Py5sJxVieRLML7jzO6yeSS1tUtGMBz+xbpneCaN3O8IzQskoI99CqwyH SZtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721653589; x=1722258389; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ensa/m/Mn9bhaexLvPaDgTLeVijtjb4maDtg90FQukY=; b=baKFA1qwLbFIF/QLqFdC9tMLWtPxX0t5dmXbygevY14U8xJPRaVg+8f7NV6pkmtWdW StEdG4WymmZIHjJgwvH8+YtcW6hsJDNFGlt5loT6xnhgv6kkBVboXc7OTyBWgX1orgHb ZbfbEikm9wGGKpDt94n5RMWFye72gT+s8JSY4Vx7vqGSEyNdpqztzDCB4hKl+9+C8IYa wFJByJWl32ov5dPg5LCncyIU0Kv48YkQRyNMUOLHK4JRRWtiLVr/zbCamxDGn1/K+VBU KhVAB6K1R1rHZG/h3SVvHLl7OzFbyVZdZgOY12MeBfcgKtjTm81O7ou2/fj3PPGsUPlr tsLA== X-Forwarded-Encrypted: i=1; AJvYcCUNPzyuq1/1wNp4LvzPeyqCWGAX7Q5a/xYGBxc65GOnR3jR5BCY8fBdi+6g8yQKPBwLxYn/DpLLikb4PCA= X-Gm-Message-State: AOJu0Ywm17M49zVnbkKVDA9B9A8WMniTEGxdUlEJRKG3in9hQrvHkZXh vvS0M+FyCXK1uxRfU4mKFfWZH27yM/JDNWMyXMi+yv1bXEe22LSDlZ07ytINBRRjcle/CQtD5qw Isxk= X-Google-Smtp-Source: AGHT+IHD4ngH/KsVYjrPY9rjclLzTTnsH/PYYAI59vPsIAEl40JAlXS+mw5nT46gFUdvPaKIxYJJAg== X-Received: by 2002:a05:6512:3403:b0:52e:943c:c61a with SMTP id 2adb3069b0e04-52ef8db6275mr4991734e87.57.1721653589226; Mon, 22 Jul 2024 06:06:29 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a3c8bf32esm420503966b.134.2024.07.22.06.06.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jul 2024 06:06:28 -0700 (PDT) Message-ID: <54c4165b-d986-4751-9907-9b54bb52a7b4@pantheon.tech> Date: Mon, 22 Jul 2024 15:06:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dts: fix DPDK git tarball cast bug To: Alex Chapman , dev@dpdk.org Cc: Honnappa Nagarahalli , Jack Bond-Preston , Luca Vizzarro , Paul Szczepanek References: <20240719153445.277851-1-alex.chapman@arm.com> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240719153445.277851-1-alex.chapman@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Reviewed-by: Juraj Linkeš Thanks for catching this. On 19. 7. 2024 17:34, Alex Chapman wrote: > When running DTS with a git revision specified the following error occurs: > $ ./main.py --revision HEAD > [...] > FileNotFoundError: [Errno 2] No such file or directory: > 'dts/' > > Fix by casting DPDKGitTarball to Path, in order to stringify it correctly. > > Bugzilla ID: 1496 > Fixes: a23f22457dbd ("dts: constrain DPDK source argument") > > Signed-off-by: Alex Chapman > Reviewed-by: Jack Bond-Preston > Reviewed-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek > --- > Hello, > Sending this fix to a bug that i discovered. > > Best Regards, > Alex > --- > .mailmap | 1 + > dts/framework/settings.py | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.mailmap b/.mailmap > index 3f3f0442e5..a326e8e553 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -46,6 +46,7 @@ Aleksey Baulin > Aleksey Katargin > Ales Musil > Alessio Igor Bogani > +Alex Chapman > Alexander Bechikov > Alexander Belyakov > Alexander Chernavin > diff --git a/dts/framework/settings.py b/dts/framework/settings.py > index f95876113f..f6303066d4 100644 > --- a/dts/framework/settings.py > +++ b/dts/framework/settings.py > @@ -415,7 +415,7 @@ def get_settings() -> Settings: > args = parser.parse_args() > > if args.dpdk_revision_id: > - args.dpdk_tarball_path = DPDKGitTarball(args.dpdk_revision_id, args.output_dir) > + args.dpdk_tarball_path = Path(DPDKGitTarball(args.dpdk_revision_id, args.output_dir)) > > args.test_suites = _process_test_suites(parser, args.test_suites) >