From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5B402A0503;
	Thu, 19 May 2022 09:05:14 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 021AE40150;
	Thu, 19 May 2022 09:05:14 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 2774540140
 for <dev@dpdk.org>; Thu, 19 May 2022 09:05:13 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 267C28A;
 Thu, 19 May 2022 10:05:12 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 267C28A
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1652943912;
 bh=Z11qaEWGY05QSnQkSq6HtEkG4bl/EzBRn6xooS/6p2U=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=wnc8o/YdwkJ6exSM7ZUBsMX2RCi1V0zp17Pof5JC1+YkkJhAZLJQ51X6aPHkE7+vR
 4OKAYPvTDI2qP3S8UaJei61fMyuDDfHT2QpCxslolqAZ44HbmVDN0RvXGYfF+O2elm
 7wBL/Q5o6n8ZAldpzF3ICLs4s0ZQZ2lpKp3NVl5Q=
Message-ID: <54d4a40d-097e-584f-28ff-09d8738aab7b@oktetlabs.ru>
Date: Thu, 19 May 2022 10:05:11 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [dpdk-dev] [PATCH v5] ethdev: mtr: support protocol based input
 color selection
Content-Language: en-US
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, Ray Kinsella <mdr@ashroe.eu>,
 Ferruh Yigit <ferruh.yigit@xilinx.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>, Andrew Boyer
 <aboyer@pensando.io>, Beilei Xing <beilei.xing@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 Chas Williams <chas3@att.com>, "Xia, Chenbo" <chenbo.xia@intel.com>,
 Ciara Loftus <ciara.loftus@intel.com>,
 Devendra Singh Rawat <dsinghrawat@marvell.com>,
 Ed Czeck <ed.czeck@atomicrules.com>, Evgeny Schemeilin <evgenys@amazon.com>,
 Gaetan Rivet <grive@u256.net>, Gagandeep Singh <g.singh@nxp.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>, Haiyue Wang <haiyue.wang@intel.com>,
 Harman Kalra <hkalra@marvell.com>, heinrich.kuhn@corigine.com,
 Hemant Agrawal <hemant.agrawal@nxp.com>, Hyong Youb Kim <hyonkim@cisco.com>,
 Igor Chauskin <igorch@amazon.com>, Igor Russkikh <irusskikh@marvell.com>,
 Jakub Grajciar <jgrajcia@cisco.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>,
 Jian Wang <jianwang@trustnetic.com>, Jiawen Wu <jiawenwu@trustnetic.com>,
 Jingjing Wu <jingjing.wu@intel.com>, John Daley <johndale@cisco.com>,
 John Miller <john.miller@atomicrules.com>,
 "John W. Linville" <linville@tuxdriver.com>,
 "Wiles, Keith" <keith.wiles@intel.com>,
 Kiran Kumar K <kirankumark@marvell.com>, Lijun Ou <oulijun@huawei.com>,
 Liron Himi <lironh@marvell.com>, Long Li <longli@microsoft.com>,
 Marcin Wojtas <mw@semihalf.com>, Martin Spinler <spinler@cesnet.cz>,
 Matan Azrad <matan@nvidia.com>, Matt Peters <matt.peters@windriver.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Michal Krawczyk <mk@semihalf.com>, "Min Hu (Connor" <humin29@huawei.com>,
 Pradeep Kumar Nalla <pnalla@marvell.com>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Radha Mohan Chintakuntla <radhac@marvell.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Rasesh Mody <rmody@marvell.com>, Rosen Xu <rosen.xu@intel.com>,
 Sachin Saxena <sachin.saxena@oss.nxp.com>,
 Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>,
 Shahed Shaikh <shshaikh@marvell.com>, Shai Brandes <shaibran@amazon.com>,
 Shepard Siegel <shepard.siegel@atomicrules.com>,
 Somalapuram Amaranath <asomalap@amd.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>,
 Stephen Hemminger <sthemmin@microsoft.com>,
 Steven Webster <steven.webster@windriver.com>,
 Sunil Kumar Kori <skori@marvell.com>, Tetsuya Mukawa <mtetsuyah@gmail.com>,
 Veerasenareddy Burru <vburru@marvell.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 Xiao Wang <xiao.w.wang@intel.com>,
 Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Yisen Zhuang <yisen.zhuang@huawei.com>, Yong Wang <yongwang@vmware.com>,
 Ziyang Xuan <xuanziyang2@huawei.com>
References: <20220421180241.514767-1-jerinj@marvell.com>
 <20220501144637.3757757-1-jerinj@marvell.com>
 <7ee66146-93e1-36c6-7954-b498af8a1ec8@oktetlabs.ru>
 <CALBAE1PiUr0b0FPJ7dAayL=E-x1TAcHdh+q_Z8NsKLSVc+GY2A@mail.gmail.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <CALBAE1PiUr0b0FPJ7dAayL=E-x1TAcHdh+q_Z8NsKLSVc+GY2A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 5/12/22 14:03, Jerin Jacob wrote:
> On Thu, May 12, 2022 at 1:06 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>
>> Hi Jerin,
> 
> Hi Andrew,
> 
>>
>> On 5/1/22 17:46, jerinj@marvell.com wrote:
>>> From: Jerin Jacob <jerinj@marvell.com>
>>>
>>> Currently, meter object supports only DSCP based on input color table,
>>> The patch enhance that to support VLAN based input color table,
>>> color table based on inner field for the tunnel use case, and
>>> support for fallback color per meter if packet based on a different field.
>>>
>>> All of the above features are exposed through capability and added
>>> additional capability to specify the implementation supports
>>> more than one input color table per ethdev port.
>>>
>>> Suggested-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>>
>> the patch LGTM, but I have a couple of questions to clarify:
>>
>> 1. Will we have API usage patches in the release cycle (I guess
>>      testpmd)?
>>
>> 2. Will we have net driver patches which add support for
>>      new driver callbacks and advertise added capabilities?
> 
> Yes. Both will be there for this release. Most likely post rc1.
> 
> We have testpmd, cnxk driver changes for the v1 version of the
> spec[1]. We will update both for the latest spec version.(We just
> awaiting for spec to merge)
> 
> [1]
> https://patches.dpdk.org/project/dpdk/patch/20220301090056.1042866-3-skori@marvell.com/
> https://patches.dpdk.org/project/dpdk/patch/20220301090056.1042866-2-skori@marvell.com/
> 
>>
>> Thanks,
>> Andrew.

Applied, thanks.