From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by dpdk.org (Postfix) with ESMTP id 7E4C35F28 for ; Tue, 5 Feb 2019 22:08:04 +0100 (CET) Received: by mail-qt1-f196.google.com with SMTP id y4so70072qtc.10 for ; Tue, 05 Feb 2019 13:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Fwl5z7TpCOnz99TKTQWf1a4RfccuDu6WALKXouteZBs=; b=EYqA6Ce4S4HSTVG2f3C5JRQMMYDqg93cbxbTscMUPST/lT8k/xNhwnFlXt45fnK8zU g55xdhM6ZGkGZq3RLOxbM1wYvcUnYsQ3crAfFW6oEQRp1xF5/L1n9MNOkYeDr6y+Uo9f 2+EBuWttgUuUWtNVIrubAuW7QI8NUCdM8revN6LVNFLFRkYLQtToQSQegHziDFR2CWoV TspxzBpi3AW+XEWqEEo1GAOHlsI0l1l52cvgYmcH3hNsuJYZgo8bFvE//b67olO2V0qQ OQ4o4vDAvAPVyZ2pkSKjuhbMKYMAAmpeCvjusSjWeexYzBGLBA1MApsUFu3XtCI5zclQ Tnbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Fwl5z7TpCOnz99TKTQWf1a4RfccuDu6WALKXouteZBs=; b=mF2ta4OSos5dFeVuFoV2DUap1hfpAw5BR6UyYdRh+8I315dxPLozVcw16Qpgv5Cqy3 NXNe3xV3qt3eMi1S3KQY38Z0BBv1DhNyj8YhUL2TlqMiTIfn+jIvjp9yv5hJgXYeiUEW UMD3OgdLc9cPgfybDoi3tsuH4mxZaAhsMt1JPL8zBKxYL2nNtzCV77Z5uxZwolG7n8MM DEOihvwYZuF3oAt20pe4RYrByG03wHV3t5QBnPaWlEIArlwd1fxGbXjao5hZbUx9M2Ts iVa+U8htX7VrmthHfBTmPzO1ojTGb5lK2J0e2RKBuCQ0GuGQvOGjK7guaV2kP3s7tWps 5A1Q== X-Gm-Message-State: AHQUAuaFU+af6TaSrAhe94zuvkUPJvqtpvaSrCyb+jeCqr1SaEgvC/u1 nDFr6SHiFOjxl6ODZ+OKlIQ= X-Google-Smtp-Source: AHgI3Ibc4jkIRid6GLYs3acqz2HrswAv/vE4eoAE32/kDN3fRME5ovZVVtqgxgOAsEAF31zFC1Vs8w== X-Received: by 2002:ac8:3078:: with SMTP id g53mr5176107qte.77.1549400883767; Tue, 05 Feb 2019 13:08:03 -0800 (PST) Received: from [192.168.1.10] (pool-96-255-82-34.washdc.fios.verizon.net. [96.255.82.34]) by smtp.gmail.com with ESMTPSA id y68sm15026044qkd.49.2019.02.05.13.08.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Feb 2019 13:08:02 -0800 (PST) To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net References: <20190131021858.5832-1-3chas3@gmail.com> <20190131235326.10648-1-3chas3@gmail.com> <20190204094906.GC21148@bricha3-MOBL.ger.corp.intel.com> From: Chas Williams <3chas3@gmail.com> Message-ID: <54dc55b6-aa63-7390-3b7a-2ffbc7f1e2f2@gmail.com> Date: Tue, 5 Feb 2019 16:08:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190204094906.GC21148@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2 v2] build: add option to override max ethports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Feb 2019 21:08:04 -0000 On 2/4/19 4:49 AM, Bruce Richardson wrote: > On Thu, Jan 31, 2019 at 06:53:25PM -0500, Chas Williams wrote: >> Allow users and packagers to override the default RTE_MAX_ETHPORTS. >> This adds a new meson option, max_ethports which defaults to the >> current value. >> > > Actually in this v2, you have changed it to 64 from 32. :-) Otherwise all > fine, but perhaps this can be fixed on apply if no v3. Oops. I can make it 32 again. > >> Signed-off-by: Chas Williams <3chas3@gmail.com> >> Acked-by: Bruce Richardson >> --- >> config/meson.build | 1 + >> config/rte_config.h | 1 - >> meson_options.txt | 2 ++ >> 3 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/config/meson.build b/config/meson.build >> index db32499b3..e59507065 100644 >> --- a/config/meson.build >> +++ b/config/meson.build >> @@ -103,6 +103,7 @@ endforeach >> # set other values pulled from the build options >> dpdk_conf.set('RTE_MAX_LCORE', get_option('max_lcores')) >> dpdk_conf.set('RTE_MAX_NUMA_NODES', get_option('max_numa_nodes')) >> +dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports')) >> dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('use_hpet')) >> dpdk_conf.set('RTE_EAL_ALLOW_INV_SOCKET_ID', get_option('allow_invalid_socket_id')) >> # values which have defaults which may be overridden >> diff --git a/config/rte_config.h b/config/rte_config.h >> index d3732e953..7606f5d7b 100644 >> --- a/config/rte_config.h >> +++ b/config/rte_config.h >> @@ -51,7 +51,6 @@ >> #define RTE_PKTMBUF_HEADROOM 128 >> >> /* ether defines */ >> -#define RTE_MAX_ETHPORTS 32 >> #define RTE_MAX_QUEUES_PER_PORT 1024 >> #define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 >> #define RTE_ETHDEV_RXTX_CALLBACKS 1 >> diff --git a/meson_options.txt b/meson_options.txt >> index 574054597..499573ed4 100644 >> --- a/meson_options.txt >> +++ b/meson_options.txt >> @@ -18,6 +18,8 @@ option('lib_musdk_dir', type: 'string', value: '', >> description: 'path to the MUSDK library installation directory') >> option('machine', type: 'string', value: 'native', >> description: 'set the target machine type') >> +option('max_ethports', type: 'string', value: '64', >> + description: 'maximum number of Ethernet devices in EAL') >> option('max_lcores', type: 'string', value: '128', >> description: 'maximum number of cores/threads supported by EAL') >> option('max_numa_nodes', type: 'string', value: '4', >> -- >> 2.17.2 >>