From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A951A04C8; Fri, 18 Sep 2020 10:55:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B1711D934; Fri, 18 Sep 2020 10:55:04 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id BE87B1D930 for ; Fri, 18 Sep 2020 10:55:02 +0200 (CEST) IronPort-SDR: N65hQW/icoWtQZ7k8CW9hKX4HvudgnZVO3k/xr4pylDFtpH/Lsw8/GFdAltZ+YzalimBD+IvpF yFCGaijEERuQ== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="139897571" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="139897571" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 01:55:01 -0700 IronPort-SDR: 7W4hKkHYHRffXn9o/4Qgu2gc9prWf2ajFjyrHKXfX+r5/tljFd46AOB56kWPtC7sDTAxCXG6Ln lJ5+M6XiYXjg== X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="484117033" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.248]) ([10.213.227.248]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 01:55:00 -0700 To: Chengchang Tang , dev@dpdk.org Cc: linuxarm@huawei.com, thomas@monjalon.net, arybchenko@solarflare.com, wenzhuo.lu@intel.com, maryam.tahhan@intel.com References: <1592483709-7076-1-git-send-email-tangchengchang@huawei.com> <1599296854-56620-1-git-send-email-tangchengchang@huawei.com> <1599296854-56620-3-git-send-email-tangchengchang@huawei.com> From: Ferruh Yigit Message-ID: <54de0895-da1a-79d5-2962-c4fab3972ac7@intel.com> Date: Fri, 18 Sep 2020 09:54:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <1599296854-56620-3-git-send-email-tangchengchang@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/5] app/testpmd: add Rx buffer size display in queue info query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/5/2020 10:07 AM, Chengchang Tang wrote: > Add Rx buffer size to queue info querry cmd so that the user can get the > buffer length used by HW queue for receiving packets. > > Signed-off-by: Chengchang Tang > Reviewed-by: Wei Hu (Xavier) > --- > app/test-pmd/config.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 30bee33..b432ac6 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -452,6 +452,7 @@ rx_queue_infos_display(portid_t port_id, uint16_t queue_id) > (qinfo.conf.rx_deferred_start != 0) ? "on" : "off"); > printf("\nRX scattered packets: %s", > (qinfo.scattered_rx != 0) ? "on" : "off"); > + printf("\nRX buffer size: %hu", qinfo.rx_buf_size); Since this field is optional for PMD to fill, it may be confusing to display buffer size as "0". What do you think print this value when "qinfo.rx_buf_size != 0"?