From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 86C595A6A for ; Thu, 12 Mar 2015 11:24:47 +0100 (CET) Received: by paceu11 with SMTP id eu11so19497059pac.1 for ; Thu, 12 Mar 2015 03:24:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=BCY1myNfizs8gaeoHbBfJB1m5rwW+0zkVSu+fIxcFHQ=; b=ByTV3MLwKRQsz0QrIOcMbmJhyMSMkIb3oqMufkRj56xGfUXP4qDFfGPlFVjomT1dXW /lWKe2wZDXj92WYleQBDZ7ovBYuryUftzVSr5txx31DAOjWvw3F548VwplU8+p5oSvI3 xB3od8RjM1TRhC0bX9OTJ0eWoLY5AS0SBXY83EwVzNpZ7OSXkT52j3on62toozkubfsT UoMkZCo481QBvFhk0sHNmlx3t9p1VnqYLKS9M0RIzPfHHZMIA4fhsExLeEa4i65EDOgo 4HE9/p2Dilp7xV+dUfjHFdlMfxIVTjaevtI+hxL44gT32Luhl1hWW0swfJPKO/lpgfjw qYEA== X-Gm-Message-State: ALoCoQlPWx0lGx+xMoqkoT0lyXdnlTTyuW/xtyE3RGlutploVK73gYYl7Z3/75g9iJ8NeitMznrc X-Received: by 10.70.103.101 with SMTP id fv5mr87622866pdb.5.1426155886869; Thu, 12 Mar 2015 03:24:46 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id sm5sm10339385pac.10.2015.03.12.03.24.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Mar 2015 03:24:46 -0700 (PDT) Message-ID: <5501696C.30506@igel.co.jp> Date: Thu, 12 Mar 2015 19:24:44 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Iremonger, Bernard" , "dev@dpdk.org" References: <1425438703-18895-1-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C2049EF578@IRSMSX108.ger.corp.intel.com> <54FD042F.4000701@igel.co.jp> In-Reply-To: <54FD042F.4000701@igel.co.jp> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/3] BSD: Support Port Hotplug function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2015 10:24:48 -0000 On 2015/03/09 11:23, Tetsuya Mukawa wrote: > On 2015/03/06 19:32, Iremonger, Bernard wrote: > >> Hi Tetsuya, >> >> The above functions being added to /lib/librte_eal/bsdapp/eal/eal_pci.= c are very similar to the functions >> in lib/librte_eal/linuxapp/eal/eal_pci.c the main difference seems to = be "struct uio_resource *uio_res" in bsd >> and "struct mapped_pci_resource *uio_res " in linux. >> Both of these structures are the same although named differently. >> There are at present only 3 references to "struct uio_resource" in l= ibrte_eal/bsdapp/eal/eal_pci.c. If "struct uio_resource" was renamed to"= struct mapped_pci_resource " the functions being added to bsdapp/eal/e= al_pci.c would be the same as the functions in linuxapp/eal/eal_pci.c. >> If both groups of functions were the same it would make sense to have= only one copy of these functions which could be moved into librte_eal/c= ommon/eal_common_pci.c . >> >> There may be some extra work in doing this but I think it would make = the code more maintainable in the future. >> What do you think? > Hi Bernard, > > Yes, I agree with it. > I will merge above, and submit again. > Thanks for suggestion. > > Regards, > Tetsuya > Hi Bernard, I've sent v2 patches. The patches depends on the latest master branch. So if you apply it, could you please pull first? Also, I tried to separate patches for reviewer, but if you feel it should be squashed more, please let me know. Thanks, Tetsuya