From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id 0C3915A95 for ; Fri, 13 Mar 2015 12:51:55 +0100 (CET) Received: by wesw62 with SMTP id w62so22780069wes.0 for ; Fri, 13 Mar 2015 04:51:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=sBezmy3e+PNTDLQFbKKswPqLqtw3hhXPrPAJfPE8484=; b=gHSrA5XKpWWgtfUlBPq5mPttcKjHrJTzat/oICoCDw6p9KIP0ohjCGcttytFKdSPJl BCCupdBhDaLet/nu1JYNWvgWcV6+LhTvNa/3cq/x1QPRvbe2I1/kFYvc7DQHDkGbBfFu NOWqqmYN0w0yKIRXJT0hGWKcwqMzAvBkLenfydmLcjAQSUg2i+3I7LZP5060d22H+Utq y2FtAuDRO9ApThr9dZXZzh8QXFCSP57SRq9GSNz3NNIz+u2A3hbVwUgpqoQzeOb/7aWl 8fbj9yRCBj6nAR+5upadK235HUjYeRHZ2LMviyOsSWV4GNA9eHmlzsYF/BpE62uln0aW 2zIg== X-Gm-Message-State: ALoCoQnYRXexB6+tWhUNqB+Vt6h5asO+GfPqrbfgeebkOXjzVvLmzWVlg7HSbVM07UOxqG/bkQ8i X-Received: by 10.180.80.9 with SMTP id n9mr96225755wix.34.1426247514888; Fri, 13 Mar 2015 04:51:54 -0700 (PDT) Received: from [10.0.0.2] ([109.65.117.109]) by mx.google.com with ESMTPSA id fo8sm2462425wib.14.2015.03.13.04.51.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Mar 2015 04:51:54 -0700 (PDT) Message-ID: <5502CF58.3050504@cloudius-systems.com> Date: Fri, 13 Mar 2015 13:51:52 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Ananyev, Konstantin" , "dev@dpdk.org" References: <1426195052-4640-1-git-send-email-vladz@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F5E9B@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258213F5E9B@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2015 11:51:55 -0000 On 03/13/15 13:07, Ananyev, Konstantin wrote: > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Thursday, March 12, 2015 9:17 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow >> >> This series contains some bug fixes that were found during my work on the ixgbe LRO >> patches. Sending this series separately on Thomas request so that it may be integrated >> into the 2.0 release. >> >> New in v3: >> - Adjusted to the new structs naming in the master. >> - Fixed rx_bulk_alloc_allowed and rx_vec_allowed initialization: >> - Don't set them to FALSE in rte_eth_dev_stop() flow - the following >> rte_eth_dev_start() will need them. >> - Reset them to TRUE in rte_eth_dev_configure() and not in a probe() flow. >> This will ensure the proper behaviour if port is re-configured. >> - Rename: >> - ixgbe_rx_vec_condition_check() -> ixgbe_rx_vec_dev_conf_condition_check() >> - set_rx_function() -> ixgbe_set_rx_function() >> - Clean up the logic in ixgbe_set_rx_function(). >> - Define stubs with __attribute__((weak)) instead of using #ifdef's. >> - Styling: beautify ixgbe_rxtx.h a bit. >> >> New in v2: >> - Fixed a compilation failure. >> >> >> Vlad Zolotarov (3): >> ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when >> reading/setting HW ring descriptor fields >> ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices >> ixgbe: Unify the rx_pkt_bulk callback initialization >> >> lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 + >> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 13 +- >> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 216 +++++++++++++++++++++----------- >> lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 28 ++++- >> lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- >> 5 files changed, 183 insertions(+), 78 deletions(-) >> > Acked-by: Konstantin Ananyev > > Just one nit: > > +int __attribute__((weak)) ixgbe_rxq_vec_setup( > + struct ixgbe_rx_queue __rte_unused *rxq) > +{ > > Please use notation: > int __attribute__((weak)) > ixgbe_rxq_vec_setup(struct ixgbe_rx_queue __rte_unused *rxq) > > To keep up with the rest of the code, plus makes much easier to read. I took an example from kni/ethtool/igb/kcompat.h for a template but no problem. Do u want me to respin or it's ok? I will use this format for the follow-up LRO patch anyway... > >> -- >> 2.1.0