From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 95AEB58CB for ; Mon, 16 Mar 2015 08:52:55 +0100 (CET) Received: by wibg7 with SMTP id g7so30517398wib.1 for ; Mon, 16 Mar 2015 00:52:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=jb9csclfHmAz95yZXT4H2bKLshaiaNJgapBv28jliYE=; b=k74i3q4XJ+Ev1ORRucc2Ih8STfsaZI+/UFHNe/4bqksdVZYShRB2XKlgIUURSkHSAZ p/ECy5kuJpl4wOhy1FiPZfGDJ15i+G02GrBZXII0sRt6LtchO0wYP3La39836wKDux/n woCRQkUPWEbqhvKgPRK44IBNlnwa/lgOviA2P4M4cajvCcJZ341v9pST7bTilZFLVXjO jyKKUuNGZnAKTqcaf4TgKfgsSXIIje8kJdjND4iva1NL+78VGogEMZ+gXYwOyYYGG7S2 iFFMlLlgKXdjtTAqqwlnRt+cnBGdUlwo4Mv1iXDabRFC5zfWmiLn1xumjssv8hTSg/pA Y//Q== X-Gm-Message-State: ALoCoQn2siNyiXMcWnIicM2aHDQxroGw+A/+KP5YbuVrUDKSjqI6aWuww2IO33j6NLcZL7wcrIU+ X-Received: by 10.180.187.12 with SMTP id fo12mr96990329wic.29.1426492375441; Mon, 16 Mar 2015 00:52:55 -0700 (PDT) Received: from [10.0.0.2] (bzq-109-65-117-109.red.bezeqint.net. [109.65.117.109]) by mx.google.com with ESMTPSA id r15sm14121175wiw.12.2015.03.16.00.52.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Mar 2015 00:52:54 -0700 (PDT) Message-ID: <55068BD5.9090000@cloudius-systems.com> Date: Mon, 16 Mar 2015 09:52:53 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Konstantin Ananyev References: <1426195052-4640-1-git-send-email-vladz@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F5E9B@irsmsx105.ger.corp.intel.com> <5502CF58.3050504@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F63E2@irsmsx105.ger.corp.intel.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2015 07:52:55 -0000 On 03/13/15 15:03, Vladislav Zolotarov wrote: > > > On Mar 13, 2015 2:51 PM, "Ananyev, Konstantin" > > > wrote: > > > > Hi Vlad, > > > > > -----Original Message----- > > > From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com > ] > > > Sent: Friday, March 13, 2015 11:52 AM > > > To: Ananyev, Konstantin; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF > PMD Rx flow > > > > > > > > > > > > On 03/13/15 13:07, Ananyev, Konstantin wrote: > > > > > > > >> -----Original Message----- > > > >> From: dev [mailto:dev-bounces@dpdk.org > ] On Behalf Of Vlad Zolotarov > > > >> Sent: Thursday, March 12, 2015 9:17 PM > > > >> To: dev@dpdk.org > > > >> Subject: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF > PMD Rx flow > > > >> > > > >> This series contains some bug fixes that were found during my > work on the ixgbe LRO > > > >> patches. Sending this series separately on Thomas request so > that it may be integrated > > > >> into the 2.0 release. > > > >> > > > >> New in v3: > > > >> - Adjusted to the new structs naming in the master. > > > >> - Fixed rx_bulk_alloc_allowed and rx_vec_allowed > initialization: > > > >> - Don't set them to FALSE in rte_eth_dev_stop() flow - > the following > > > >> rte_eth_dev_start() will need them. > > > >> - Reset them to TRUE in rte_eth_dev_configure() and not > in a probe() flow. > > > >> This will ensure the proper behaviour if port is > re-configured. > > > >> - Rename: > > > >> - ixgbe_rx_vec_condition_check() -> > ixgbe_rx_vec_dev_conf_condition_check() > > > >> - set_rx_function() -> ixgbe_set_rx_function() > > > >> - Clean up the logic in ixgbe_set_rx_function(). > > > >> - Define stubs with __attribute__((weak)) instead of using > #ifdef's. > > > >> - Styling: beautify ixgbe_rxtx.h a bit. > > > >> > > > >> New in v2: > > > >> - Fixed a compilation failure. > > > >> > > > >> > > > >> Vlad Zolotarov (3): > > > >> ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when > > > >> reading/setting HW ring descriptor fields > > > >> ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 > devices > > > >> ixgbe: Unify the rx_pkt_bulk callback initialization > > > >> > > > >> lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 + > > > >> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 13 +- > > > >> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 216 > +++++++++++++++++++++----------- > > > >> lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 28 ++++- > > > >> lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- > > > >> 5 files changed, 183 insertions(+), 78 deletions(-) > > > >> > > > > Acked-by: Konstantin Ananyev > > > > > > > > > Just one nit: > > > > > > > > +int __attribute__((weak)) ixgbe_rxq_vec_setup( > > > > + struct ixgbe_rx_queue __rte_unused *rxq) > > > > +{ > > > > > > > > Please use notation: > > > > int __attribute__((weak)) > > > > ixgbe_rxq_vec_setup(struct ixgbe_rx_queue __rte_unused *rxq) > > > > > > > > To keep up with the rest of the code, plus makes much easier to > read. > > > > > > I took an example from kni/ethtool/igb/kcompat.h for a template but no > > > problem. > > > Do u want me to respin or it's ok? I will use this format for the > > > follow-up LRO patch anyway... > > > > Doing that in LRO patch set is ok. > > No need for respin that one, I think. > > Great! Thanks a lot for reviewing this. > > Thomas, it seems like ixgbe maintainer gives this series a green > light!.. ;) > Ping. Thomas, could u, pls., consider applying this series to at least the upstream master? thanks in advance, vlad > > Konstantin > > > > > > > > > > > > >> -- > > > >> 2.1.0 > > >