From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 6041C569C for ; Thu, 19 Mar 2015 12:26:28 +0100 (CET) Received: by wgra20 with SMTP id a20so59536001wgr.3 for ; Thu, 19 Mar 2015 04:26:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=OxE6Ja2sy/zWM1+0PI7/5dcErt2VikjGH6U0K8x8EEM=; b=E5e2WHP3NRYCxUv5Ycsa+lf+2hpnVEr+G3ODbWbhpGK+Q5N2lk2BCImOf85vXU17LB sDbOdlqO7H0/DTiO2l8HzqzSxkejdt6BTVNM1blZGQXNdX8JTbvlNAWFHlCGDDsRtpq/ Q/893IH6In0E2uSfewBoQBDn4L4R/MGsZWQ79oqf4i9bUJiU1U63YCfDfUtek7Nr4FNj PFMArjO5QetLF1d2FPS3yREnCVWj+67xfZ5PnW6Mo19ocf9NsUA3+uV/qfipyYrO7JdX bfTF8xpGWwI8Sm+0ySzW0z2w/rCgOdukeDWLK15qZGanqIJqjRA46/e8lChbmzokrVnz 3BPQ== X-Gm-Message-State: ALoCoQnozpIDR9rfWC4md4q9sh6GucELnGQBkwav1quJNxDd/dQYHiL8+t9W2EfFIBGF8VGkPsfu X-Received: by 10.180.20.177 with SMTP id o17mr15228237wie.66.1426764388249; Thu, 19 Mar 2015 04:26:28 -0700 (PDT) Received: from alcyon.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id l9sm2068387wij.16.2015.03.19.04.26.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Mar 2015 04:26:27 -0700 (PDT) Message-ID: <550AB263.5070607@6wind.com> Date: Thu, 19 Mar 2015 12:26:27 +0100 From: David Marchand User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Stephen Hemminger References: <1425928715-2980-1-git-send-email-stephen@networkplumber.org> <1425928715-2980-2-git-send-email-stephen@networkplumber.org> In-Reply-To: <1425928715-2980-2-git-send-email-stephen@networkplumber.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: silence noisy log messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 11:26:28 -0000 On 03/09/2015 08:18 PM, Stephen Hemminger wrote: > The ixgbe driver likes to be far to chatty in the system log > which is good for the original developer but not good for a production > product. > > Reduce the log spam by doing: > * All the normal messages should be changed from INFO to DEBUG. > * The log messages should be done with RTE_LOG so that they can be > compiled out if RTE_LOG_LEVEL is set. > * The link state print routine prints more than is necessary > PCI information is already known (earlier in log) and has > no purpose here. > > Signed-off-by: Stephen Hemminger This patch is broken. The changes are there twice. I removed the first part of the mail. > --- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 15 +++++---------- > lib/librte_pmd_ixgbe/ixgbe_logs.h | 3 +-- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 12 ++++++------ > 3 files changed, 12 insertions(+), 18 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > index 9bdc046..171809f 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > @@ -2293,20 +2293,15 @@ ixgbe_dev_link_status_print(struct rte_eth_dev *dev) > memset(&link, 0, sizeof(link)); > rte_ixgbe_dev_atomic_read_link_status(dev, &link); > if (link.link_status) { > - PMD_INIT_LOG(INFO, "Port %d: Link Up - speed %u Mbps - %s", > - (int)(dev->data->port_id), > + PMD_INIT_LOG(DEBUG, "Port %u: Link Up - speed %u Mbps - %s", > + dev->data->port_id, > (unsigned)link.link_speed, > link.link_duplex == ETH_LINK_FULL_DUPLEX ? > "full-duplex" : "half-duplex"); > } else { > - PMD_INIT_LOG(INFO, " Port %d: Link Down", > - (int)(dev->data->port_id)); > - } > - PMD_INIT_LOG(INFO, "PCI Address: %04d:%02d:%02d:%d", > - dev->pci_dev->addr.domain, > - dev->pci_dev->addr.bus, > - dev->pci_dev->addr.devid, > - dev->pci_dev->addr.function); > + PMD_INIT_LOG(DEBUG, "Port %d: Link Down", > + dev->data->port_id); > + } > } Well, I would say that PMD_INIT_LOG should not be called from here. PMD_DRV_LOG should be the preferred macro (pure debug stuff, out of init). The rest looks fine to me. -- David Marchand