From: Linhaifeng <haifeng.lin@huawei.com>
To: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_pmd_virtio fix can't receive packets after rx_q is empty If failed to alloc mbuf ring_size times the rx_q may be empty and can't receive any packets forever because nb_used is 0 forever.
Date: Fri, 20 Mar 2015 17:45:19 +0800 [thread overview]
Message-ID: <550BEC2F.2030600@huawei.com> (raw)
In-Reply-To: <1426842609-26700-1-git-send-email-haifeng.lin@huawei.com>
Sorry for my wrong title. Please ignore it.
On 2015/3/20 17:10, linhaifeng wrote:
> From: Linhaifeng <haifeng.lin@huawei.com>
>
> so we should try to refill when nb_used is 0.After otherone free mbuf
> we can restart to receive packets.
>
> Signed-off-by: Linhaifeng <haifeng.lin@huawei.com>
> ---
> lib/librte_pmd_virtio/virtio_rxtx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c b/lib/librte_pmd_virtio/virtio_rxtx.c
> index 1d74b34..5c7e0cd 100644
> --- a/lib/librte_pmd_virtio/virtio_rxtx.c
> +++ b/lib/librte_pmd_virtio/virtio_rxtx.c
> @@ -495,7 +495,7 @@ virtio_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
> num = num - ((rxvq->vq_used_cons_idx + num) % DESC_PER_CACHELINE);
>
> if (num == 0)
> - return 0;
> + goto refill;
>
> num = virtqueue_dequeue_burst_rx(rxvq, rcv_pkts, len, num);
> PMD_RX_LOG(DEBUG, "used:%d dequeue:%d", nb_used, num);
> @@ -536,6 +536,7 @@ virtio_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
>
> rxvq->packets += nb_rx;
>
> +refill:
> /* Allocate new mbuf for the used descriptor */
> error = ENOSPC;
> while (likely(!virtqueue_full(rxvq))) {
>
--
Regards,
Haifeng
prev parent reply other threads:[~2015-03-20 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 9:10 linhaifeng
2015-03-20 9:45 ` Linhaifeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550BEC2F.2030600@huawei.com \
--to=haifeng.lin@huawei.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).