DPDK patches and discussions
 help / color / mirror / Atom feed
From: Linhaifeng <haifeng.lin@huawei.com>
To: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] cast used->idx to volatile
Date: Mon, 23 Mar 2015 20:23:57 +0800	[thread overview]
Message-ID: <551005DD.4060508@huawei.com> (raw)
In-Reply-To: <1426925237-8312-1-git-send-email-haifeng.lin@huawei.com>



On 2015/3/21 16:07, linhaifeng wrote:
> From: Linhaifeng <haifeng.lin@huawei.com>
> 
> Same as rte_vhost_enqueue_burst we should cast used->idx
> to volatile before notify guest.
> 
> Signed-off-by: Linhaifeng <haifeng.lin@huawei.com>
> ---
>  lib/librte_vhost/vhost_rxtx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
> index 535c7a1..8d674d1 100644
> --- a/lib/librte_vhost/vhost_rxtx.c
> +++ b/lib/librte_vhost/vhost_rxtx.c
> @@ -722,7 +722,7 @@ rte_vhost_dequeue_burst(struct virtio_net *dev, uint16_t queue_id,
>  	}
>  
>  	rte_compiler_barrier();
> -	vq->used->idx += entry_success;
> +	*(volatile uint16_t *)&vq->used->idx += entry_success;
>  	/* Kick guest if required. */
>  	if (!(vq->avail->flags & VRING_AVAIL_F_NO_INTERRUPT))
>  		eventfd_write((int)vq->callfd, 1);
> 

-- 
Regards,
Haifeng

  parent reply	other threads:[~2015-03-23 12:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-21  8:07 linhaifeng
2015-03-23  2:29 ` Linhaifeng
2015-03-23 12:23 ` Linhaifeng [this message]
2015-03-23 12:54   ` Xie, Huawei
2015-03-24  0:59     ` Linhaifeng
2015-03-24  1:53       ` Xie, Huawei
2015-03-24  7:43         ` Linhaifeng
2015-03-24 10:06           ` Xie, Huawei
2015-03-24 12:28             ` Linhaifeng
2015-03-30  9:20             ` Linhaifeng
2015-03-30 15:56               ` Xie, Huawei
2015-04-01  7:50                 ` Thomas Monjalon
2015-04-01 14:40                   ` Xie, Huawei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551005DD.4060508@huawei.com \
    --to=haifeng.lin@huawei.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).