From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 51C5011C5
 for <dev@dpdk.org>; Mon, 23 Mar 2015 17:14:06 +0100 (CET)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128)
 (Exim 4.80) (envelope-from <olivier.matz@6wind.com>)
 id 1Ya53K-0001YE-RU; Mon, 23 Mar 2015 17:18:14 +0100
Message-ID: <55103BC4.5030600@6wind.com>
Date: Mon, 23 Mar 2015 17:13:56 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.5.0
MIME-Version: 1.0
To: gaohaifeng <gaohaifeng.gao@huawei.com>, jerry.lilijun@huawei.com, 
 thomas.monjalon@6wind.com, dev@dpdk.org
References: <1427098299-20876-1-git-send-email-gaohaifeng.gao@huawei.com>
In-Reply-To: <1427098299-20876-1-git-send-email-gaohaifeng.gao@huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] eal_common_options.c: set create_uio_dev
 option to no argument
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Mar 2015 16:14:06 -0000

Hi,

On 03/23/2015 09:11 AM, gaohaifeng wrote:
> From: Haifeng Gao <gaohaifeng.gao@huawei.com>
> 
> eal options OPT_CREATE_UIO_DEV does not need argument so set it to zero.
> It needs to reset create_uio_dev explicitly.
> 
> Signed-off-by: Haifeng Gao <gaohaifeng.gao@huawei.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thank you for fixing this.

Note for Thomas: the bug is there since my initial commit adding
the feature, you may want to add this to the commit log:
Fixes: f7f97c16048e (" pci: add option --create-uio-dev to run without
hotplug")


Regards,
Olivier