From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-we0-f176.google.com (mail-we0-f176.google.com
 [74.125.82.176]) by dpdk.org (Postfix) with ESMTP id 9A33C9ADA
 for <dev@dpdk.org>; Tue, 24 Mar 2015 12:19:30 +0100 (CET)
Received: by weop45 with SMTP id p45so160591782weo.0
 for <dev@dpdk.org>; Tue, 24 Mar 2015 04:19:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=4Db7ZNmeeK0wSx775O8WIHYSwWykSF00KD+I1hUZmAA=;
 b=OM/yog01RBgXWNLUmZfdzJFxCOFWK10tHJivvUIlD4ZJcXsVj73CWLJbdwFBhR8ExQ
 6sIk924ynFX2RQZrROQzis/2HS6aIjThWqWsdnnhYKuexN0t7AP4XQlHIAa6QgSwJpul
 CAe11WYRKPTVvzItwjktLzyg37Ilfmd+TDAW+aboogoaMFoVj5qCRx0wydEqQpibOgKH
 ma6UlpknLwoufX21Y7vk1R0SlYKG7oVpwZeLO3Z4wsKCJjWatFumPGtcorQJ7IFU4ZGo
 lEGtuYKO2s62iKfs3JywUF9otoOqtNEQlFeXv2BynRLIafn++Uw0HvchqqaeYoKcf6PV
 OmSQ==
X-Gm-Message-State: ALoCoQmrmgMFlW8Y+4iI6cz4FuZwNqhdQXX9//HkSqZ+KBowW4LL1pc3N2H9l0syLFzn7+KaqCn6
X-Received: by 10.194.76.69 with SMTP id i5mr7141664wjw.3.1427195970418;
 Tue, 24 Mar 2015 04:19:30 -0700 (PDT)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id m4sm5631218wjb.25.2015.03.24.04.19.29
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 24 Mar 2015 04:19:29 -0700 (PDT)
Message-ID: <55114843.5060404@6wind.com>
Date: Tue, 24 Mar 2015 12:19:31 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.3.0
MIME-Version: 1.0
To: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>, 
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>
References: <1424449085-82466-1-git-send-email-danielx.t.mrzyglod@intel.com>
 <54EC5A9C.3060008@6wind.com> <2042259.HzLBmuaM6Z@xps13>
 <60ABE07DBB3A454EB7FAD707B4BB158213902C97@IRSMSX109.ger.corp.intel.com>
In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB158213902C97@IRSMSX109.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] cmdline: fix type format from unsigned to
 size_t for buffer size
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2015 11:19:30 -0000

Hi,

On 03/24/2015 11:48 AM, Jastrzebski, MichalX K wrote:
>>> On 02/20/2015 05:18 PM, Daniel Mrzyglod wrote:
>>>> Function match_inst is used to take buffor using sizeof() which is size_t
>> type.
>>>> This modification also involved changing '%u' to '%zu' in printf function.
>>>>
>>>> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>>>>
>>>> [...]
>>>
>>> Did you see a specific issue with the current code? (maybe a compilation
>>> issue or a klocwork issue?)
> Hi Olivier, Thomas
> Yes, this is an issue reported by the static analysis tool.
>>>
>>> I think this patch is ok, but there are many places where this kind
>>> of fixes should be applied in cmdline (cmdline_parse_*(),
>>> cmdline_get_help_*(), etc.). Is there a motivation for changing it
>>> only there?
> The tool we use didn't reported other places,
> that is why Daniel send only this one change.

I think it would be great to look at other places to check if the same
change is required.

Regards,
Olivier