From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 4CDC67E23 for ; Wed, 25 Mar 2015 16:06:10 +0100 (CET) Received: by wgbcc7 with SMTP id cc7so30711407wgb.0 for ; Wed, 25 Mar 2015 08:06:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=QDFRGCtkMIVipfZxsS1dDGeDBe8MP1eNV0rf7+aLHbE=; b=hd/kiBMYgml0pWktrz606+jDD7vPQ/te561jAWrOuvpTrm3jHUGVAkapgoxQmtIRsp 84wVfDGuiSUd0Gkq29Fng0NhNZN6OnID5+3dsVoPRFGFPVQwStLD2/8lqJxeFnE5Z9Cn fRgheWRbVWodp7XuZ5qIqGr4wT7EZxPrIdX8fizWJSSP6/SRUZAiL3XBSr0+0UaCVCZz 0TqsLoLm8m5s8R2VWprvG0guSq4Ye7jhnwIdtY9AMQiBrdVnorwitHYvhUYqKVHX35Ap QpgS+EnVgduz0e3H9ueXL7ZAmxhs2udltDBzCPvDeJwoTT1X+o4HkrkXXaEMUA+Bj90t bbmg== X-Gm-Message-State: ALoCoQl9aSdM7tlXQ7fQqrNWuqIF5wZpoDh0WeB/WcGf9gXDeXiB9sNE2hyKfY5Hj5fKyQs7gNuB X-Received: by 10.194.177.167 with SMTP id cr7mr18048721wjc.19.1427295969830; Wed, 25 Mar 2015 08:06:09 -0700 (PDT) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id 17sm4086043wjt.45.2015.03.25.08.06.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Mar 2015 08:06:09 -0700 (PDT) Message-ID: <5512CEE2.60202@6wind.com> Date: Wed, 25 Mar 2015 16:06:10 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Neil Horman , John McNamara References: <1427208779-16548-1-git-send-email-john.mcnamara@intel.com> <1427208779-16548-2-git-send-email-john.mcnamara@intel.com> <20150324170058.GA13924@hmsreliant.think-freely.org> In-Reply-To: <20150324170058.GA13924@hmsreliant.think-freely.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: added make target to print out system info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2015 15:06:10 -0000 Hi, On 03/24/2015 06:00 PM, Neil Horman wrote: > On Tue, Mar 24, 2015 at 02:52:59PM +0000, John McNamara wrote: >> Added a 'make system_info' target to print out system info >> related to DPDK. This is intended as output that can be >> attached to bug reports. >> --- >> mk/rte.sdkroot.mk | 33 +++++++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk >> index e8423b0..b477d09 100644 >> --- a/mk/rte.sdkroot.mk >> +++ b/mk/rte.sdkroot.mk >> @@ -123,3 +123,36 @@ examples examples_clean: >> %: >> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig >> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk $@ >> + >> +.PHONY: system_info >> +system_info: >> + $(Q)echo >> + $(Q)echo "CC version" >> + $(Q)echo "==========" >> + $(Q)$(CC) --version >> + $(Q)echo >> + >> + $(Q)echo "DPDK version" >> + $(Q)echo "============" >> + $(Q)$(MAKE) showversion >> + $(Q)echo >> + >> + $(Q)echo "Git commit" >> + $(Q)echo "==========" >> + $(Q)git log --pretty=format:'%H' -1 >> + $(Q)echo >> + >> + $(Q)echo "Uname" >> + $(Q)echo "=====" >> + $(Q)uname -srvmpio >> + $(Q)echo >> + >> + $(Q)echo "Hugepages" >> + $(Q)echo "=========" >> + $(Q)grep -i huge /proc/meminfo >> + $(Q)echo >> + >> + $(Q)tools/cpu_layout.py >> + >> + $(Q)tools/dpdk_nic_bind.py --status >> + $(Q)echo >> -- >> 1.8.1.4 >> >> > Nak, for a few reasons: > > 1) While this target is in a common makefile, at least some of the information > it gathers is operating system specfic (e.g. /proc/meminfo). This isn't going > to work on BSD, or other operating systems that we might support in the future > > 2) This is tied to the build system. Theres no guarantee that users will > diagnose problems only on the system that they built the DPDK on. > > A better solution might be to simply document the sort of information that a bug > reporter is expected to gather, along with some sample tools for doing so. > There are numerous tools to get the above information, both in isolation and in > aggregate. I agree with Neil that the Makefile is probably not the best place to put that because the target machine may not be the build machine. What about doing the same in a script? Therefore it could be embedded and executed on the target. Neil, you talk about tools that do the same kind of things. What tool are you thinking about? The problem of using external tools is that it adds a dependency with them. Regards, Olivier